compose: have cockroach use the "postgres" database #47768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
❌ The GitHub CI (Cockroach) build has failed on c1ddc697. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
yuzefovich
approved these changes
Apr 21, 2020
There was a problem hiding this comment.
I tried to run this test manually at some point, and I believe I ran into the problem (and others you have fixed) you're describing, but this is where I stopped.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained
|
bors r+ |
Build failed (retrying...) |
Build failed (retrying...) |
Build failed (retrying...) |
Build failed (retrying...) |
Build failed (retrying...) |
craig bot
pushed a commit
that referenced
this pull request
Apr 21, 2020
47761: util/log: fix lying comment r=andreimatei a=andreimatei SetExitFunc() claimed that a nil function was a way to reset it. It wasn't; it'd lead to a crash. Release note: None 47768: compose: have cockroach use the "postgres" database r=mjibson a=mjibson This is needed because postgres can't do cross-database queries. So, we'll just use the default "postgres" database since it exists at startup, and have cockroach create and use a database of the same name. You can't connect to a database that doesn't exist in postgres, so having postgres connect to the "defaultdb" database that cockroach uses would require changing something to first create that before it connected, and the current stuff isn't designed to do that. (There's probably a way to do it in the docker image, but this is just as easy.) Release note: None Co-authored-by: Andrei Matei <andrei@cockroachlabs.com> Co-authored-by: Matt Jibson <matt.jibson@gmail.com>
Build failed (retrying...) |
Build failed |
This is needed because postgres can't do cross-database queries. So, we'll just use the default "postgres" database since it exists at startup, and have cockroach create and use a database of the same name. You can't connect to a database that doesn't exist in postgres, so having postgres connect to the "defaultdb" database that cockroach uses would require changing something to first create that before it connected, and the current stuff isn't designed to do that. (There's probably a way to do it in the docker image, but this is just as easy.) Release note: None
|
bors r+ |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed because postgres can't do cross-database queries. So,
we'll just use the default "postgres" database since it exists at startup,
and have cockroach create and use a database of the same name.
You can't connect to a database that doesn't exist in postgres, so having
postgres connect to the "defaultdb" database that cockroach uses would
require changing something to first create that before it connected,
and the current stuff isn't designed to do that. (There's probably a
way to do it in the docker image, but this is just as easy.)
Release note: None