util/log: fix lying comment #47761
Merged
util/log: fix lying comment #47761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SetExitFunc() claimed that a nil function was a way to reset it. It wasn't; it'd lead to a crash. Release note: None
|
This change is |
andreimatei
commented
Apr 21, 2020
complete! 0 of 0 LGTMs obtained
Build failed (retrying...) |
Build failed (retrying...) |
Build failed (retrying...) |
craig bot
pushed a commit
that referenced
this pull request
Apr 21, 2020
47761: util/log: fix lying comment r=andreimatei a=andreimatei SetExitFunc() claimed that a nil function was a way to reset it. It wasn't; it'd lead to a crash. Release note: None 47768: compose: have cockroach use the "postgres" database r=mjibson a=mjibson This is needed because postgres can't do cross-database queries. So, we'll just use the default "postgres" database since it exists at startup, and have cockroach create and use a database of the same name. You can't connect to a database that doesn't exist in postgres, so having postgres connect to the "defaultdb" database that cockroach uses would require changing something to first create that before it connected, and the current stuff isn't designed to do that. (There's probably a way to do it in the docker image, but this is just as easy.) Release note: None Co-authored-by: Andrei Matei <andrei@cockroachlabs.com> Co-authored-by: Matt Jibson <matt.jibson@gmail.com>
Build failed (retrying...) |
Build failed |
|
bors r+ |
Build succeeded |
knz
added a commit
to knz/cockroach
that referenced
this pull request
Jun 8, 2020
There's at lease one PR with a missing branch tips in refs/pull. This commit makes the script tolerant of that failure. Release note: None
craig bot
pushed a commit
that referenced
this pull request
Jun 8, 2020
49887: sql: populate spatial_ref_sys table with projection entries r=sumeerbhola a=otan Also fixed a bug where `\0` didn't actually output a NULL terminator (no idea why it worked). Release note (sql change): Populate the spatial_ref_sys table with support SRID entries for geospatial data types. 49917: Makefile: make PROJ compile on Publish Bleeding Edge r=petermattis a=otan As docgen relies on builtins which relies on proj, we are stuck in a situation in cross compilation where we are trying to install docgen with a non-native libproj.a file causing the linker to fail in `Upload Binaries`. Fix this by not compiling docgen on cross compilations. Also fix the windows compilation as PROJ will dump it into a libproj_4_9.a instead of libproj.a. Also make execgen not depend on LIBPROJ since it's not required. Release note: None 49920: geo: move TestClipRectByEWKT test to geoindex r=sumeerbhola a=otan Trying to make the geo package not depend on GEOS, and this is one of the required steps. Release note: None 49923: opt: incorporate operator volatility r=RaduBerinde a=RaduBerinde Incorporate volatility of operators (unary, binary, comparison) into the VolatilitySet property. Unfortunately, this modifies most plans as pretty much everything is "immutable". Perhaps once this work is behind us we will want to hide this information from plans in most cases. Release note: None 49956: scripts/release-notes: fix the error encountered on #47761 r=rmloveland a=knz Fixes #49952 There's at lease one PR with a missing branch tips in refs/pull. This commit makes the script tolerant of that failure. Release note: None 49963: lint: fix a linter message r=andreimatei a=andreimatei A message had an unescaped format and ended up rendered like: use YourFuncf("descriptive prefix %!s(MISSING)", ...) Release note: None Co-authored-by: Oliver Tan <otan@cockroachlabs.com> Co-authored-by: Radu Berinde <radu@cockroachlabs.com> Co-authored-by: Raphael 'kena' Poss <knz@thaumogen.net> Co-authored-by: Andrei Matei <andrei@cockroachlabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SetExitFunc() claimed that a nil function was a way to reset it. It
wasn't; it'd lead to a crash.
Release note: None