Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scripts/release-notes: fix the error encountered on #47761 #49956

Merged
merged 1 commit into from
Jun 8, 2020

Conversation

knz
Copy link
Contributor

@knz knz commented Jun 8, 2020

Fixes #49952

There's at lease one PR with a missing branch tips in refs/pull.
This commit makes the script tolerant of that failure.

Release note: None

@knz knz requested review from rmloveland and a team June 8, 2020 14:07
@cockroach-teamcity
Copy link
Member

This change is Reviewable

There's at lease one PR with a missing branch tips in refs/pull.
This commit makes the script tolerant of that failure.

Release note: None
Copy link
Collaborator

@rmloveland rmloveland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!1! Thanks for investigating this, Raphael!

@knz
Copy link
Contributor Author

knz commented Jun 8, 2020

bors r=rmloveland

@craig
Copy link
Contributor

craig bot commented Jun 8, 2020

Merge conflict (retrying...)

@craig
Copy link
Contributor

craig bot commented Jun 8, 2020

Build failed (retrying...)

@craig
Copy link
Contributor

craig bot commented Jun 8, 2020

Build failed (retrying...)

@craig
Copy link
Contributor

craig bot commented Jun 8, 2020

Build succeeded

@craig craig bot merged commit 15c11df into cockroachdb:master Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

scripts: release notes script fails with "'refs/pull/origin/47761' did not resolve to an object"
3 participants