Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachtest: ignore version upgrade no inbound stream connection error #53656

Merged
merged 1 commit into from
Aug 31, 2020
Merged

roachtest: ignore version upgrade no inbound stream connection error #53656

merged 1 commit into from
Aug 31, 2020

Conversation

asubiotto
Copy link
Contributor

Release justification: non-production code change

This error is fixed in 20.2, but may occur on earlier versions because version
upgrade is a mixed-version test.

Release note: None (testing change)

Closes #53393

Release justification: non-production code change

This error is fixed in 20.2, but may occur on earlier versions because version
upgrade is a mixed-version test.

Release note: None (testing change)
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@irfansharif irfansharif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's add a TODO to remove this skip once we cut the 20.2 branch.

@asubiotto
Copy link
Contributor Author

Won't we still run this roachtest on prior versions even after we cut the 20.2 branch?

@irfansharif
Copy link
Contributor

Oh, doh, you're right. I keep forgetting we don't do #51897. Sorry for the noise.

bors r+

@craig
Copy link
Contributor

craig bot commented Aug 31, 2020

This PR was included in a batch that was canceled, it will be automatically retried

@craig
Copy link
Contributor

craig bot commented Aug 31, 2020

Build succeeded:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

roachtest: acceptance/version-upgrade failed
3 participants