Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

roachtest: ignore version upgrade no inbound stream connection error #53656

Merged
merged 1 commit into from
Aug 31, 2020
Merged

roachtest: ignore version upgrade no inbound stream connection error #53656

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion pkg/cmd/roachtest/versionupgrade.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ import (
"time"

"github.com/cockroachdb/cockroach/pkg/roachpb"
"github.com/cockroachdb/cockroach/pkg/testutils"
"github.com/cockroachdb/cockroach/pkg/util/binfetcher"
"github.com/cockroachdb/cockroach/pkg/util/retry"
"github.com/cockroachdb/cockroach/pkg/util/timeutil"
Expand All @@ -28,7 +29,10 @@ import (
"github.com/stretchr/testify/require"
)

var v201 = roachpb.Version{Major: 20, Minor: 1}
var (
v201 = roachpb.Version{Major: 20, Minor: 1}
v202 = roachpb.Version{Major: 20, Minor: 2}
)

// Feature tests that are invoked between each step of the version upgrade test.
// Tests can use u.clusterVersion to determine which version is active at the
Expand Down Expand Up @@ -430,6 +434,11 @@ func stmtFeatureTest(
}
db := u.conn(ctx, t, i)
if _, err := db.ExecContext(ctx, stmt, args...); err != nil {
if testutils.IsError(err, "no inbound stream connection") && u.clusterVersion(ctx, t, i).Less(v202) {
// This error has been fixed in 20.2+ but may still occur on earlier
// versions.
return true // skipped
}
t.Fatal(err)
}
return false
Expand Down