ui: extend diagnostics column to allow activate and download reports #55164
Conversation
|
This change is |
koorosh
force-pushed
the
diagnostics-prev-bundles
branch
from
a94a8c2 to
b7a3fad
Compare
There was a problem hiding this comment.
@koorosh really appreciate the detail in the commit message. Nice work!
Reviewed 7 of 7 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained
There was a problem hiding this comment.
@koorosh I am expecting this PR to bump the admin-ui-components version, am I missing something?
Reviewable status:
Previously, Statements table had a Diagnostics column which allowed users to request diagnostics reports for the first time and then displayed status for requested report only. As result it wasn't possible to download already generated report or request new one report from statements table. With current changes, Diagnostics column allows to request new reports everytime when previous reports are generated. Also it provides a list with links to download previous reports. The main change is to provide a list of available (or requested) reports for every statement (instead of a single, most recent report as it was before). Then extracted `StatementsPage` component (from `admin-ui-components` package) handles all rendering logic for this list of reports. Minor changes: - `WAITING FOR QUERY` status is renamed to `WAITING` for new design - `getDiagnosticsStatus` utility function is reused to reduce code duplication Resolves: cockroachdb#50824 Release note (admin ui change): Diagnostics column (on statements table) has been changed and includes `Activate` button and dropdown list to download completed reports. Also diagnostics badge status is changed from `WAITING FOR QUERY` to `WAITING`.
koorosh
force-pushed
the
diagnostics-prev-bundles
branch
from
b7a3fad to
28c4f9e
Compare
@dhartunian , you're definitely right, already updated with bumped version. Thanks! |
There was a problem hiding this comment.
Reviewed 3 of 3 files at r2.
Reviewable status:
|
bors r+ |
|
Build succeeded: |
Resolves #50824
Depends on cockroachdb/admin-ui-components#31Depends on cockroachdb/yarn-vendored#42Previously, Statements table had a Diagnostics column which allowed
users to request diagnostics reports for the first time and then
displayed status for requested report only. As result it wasn't
possible to download already generated report or request new one
report from the statements table.
With current changes, Diagnostics column allows requesting new
reports every time when previous reports are generated.
Also, it provides a list with links to download previous reports.
The main change is to provide a list of available (or requested)
reports for every statement (instead of a single, most recent
report as it was before). Then extracted
StatementsPagecomponent(from
admin-ui-componentspackage) handles all rendering logicfor this list of reports.
Minor changes:
WAITING FOR QUERYstatus is renamed toWAITINGfor new designgetDiagnosticsStatusutility function is reused to reduce codeduplication
Release note (admin ui change): Diagnostics column (on statements table)
has been changed and includes
Activatebutton and dropdown list todownload completed reports. Also, diagnostics badge status is changed from
WAITING FOR QUERYtoWAITING