This repository has been archived by the owner on Jun 24, 2024. It is now read-only.
upgrade @cockroachlabs-admin-ui-components@^0.1.20 #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhartunian
approved these changes
Oct 19, 2020
craig bot
pushed a commit
to cockroachdb/cockroach
that referenced
this pull request
Oct 20, 2020
55164: ui: extend diagnostics column to allow activate and download reports r=koorosh a=koorosh Resolves #50824 ~~Depends on cockroachdb/admin-ui-components#31 ~~Depends on cockroachdb/yarn-vendored#42 Previously, Statements table had a Diagnostics column which allowed users to request diagnostics reports for the first time and then displayed status for requested report only. As result it wasn't possible to download already generated report or request new one report from the statements table. With current changes, Diagnostics column allows requesting new reports every time when previous reports are generated. Also, it provides a list with links to download previous reports. The main change is to provide a list of available (or requested) reports for every statement (instead of a single, most recent report as it was before). Then extracted `StatementsPage` component (from `admin-ui-components` package) handles all rendering logic for this list of reports. Minor changes: - `WAITING FOR QUERY` status is renamed to `WAITING` for new design - `getDiagnosticsStatus` utility function is reused to reduce code duplication Release note (admin ui change): Diagnostics column (on statements table) has been changed and includes `Activate` button and dropdown list to download completed reports. Also, diagnostics badge status is changed from `WAITING FOR QUERY` to `WAITING`  Co-authored-by: Andrii Vorobiov <and.vorobiov@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.