xform: reorganize rules and tests for consistency #55654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
RaduBerinde
approved these changes
Oct 18, 2020
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, 4 of 4 files at r2.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @rytaft)
mgartner
force-pushed
the
xform-refactor
branch
from
1b78880
to
0f6c2e8
Compare
This commit organizes exploration rules by the type of expressions they match. `GenerateZigzagJoins` and `GenerateInvertedZigzagJoins` have been moved to `select.opt`. All other rules were correctly organized. Release note: None
This commit moves around (and makes some minor necessary changes) to exploration tests so that tests for rules in `foo.opt` can be found in `testdata/foo`. Most of the changes were related to zigzag join rules which moved from `join` to `select`, and some tests for `GenerateConstrainedScans` that have lived in `scan` for years. The goal of this change is to make it easier to find tests for a specific rule and to set a precedent for future tests. Release note: None
mgartner
force-pushed
the
xform-refactor
branch
from
0f6c2e8
to
652ec80
Compare
|
bors r=RaduBerinde |
|
Build failed (retrying...): |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xform: organize rules by the type of expressions they match
This commit organizes exploration rules by the type of expressions they
match.
GenerateZigzagJoinsandGenerateInvertedZigzagJoinshave beenmoved to
select.opt. All other rules were correctly organized.Release note: None
xform: reorganize tests to match the organization of the rules
This commit moves around (and makes some minor necessary changes) to
exploration tests so that tests for rules in
foo.optcan be found intestdata/foo. Most of the changes were related to zigzag join ruleswhich moved from
jointoselect, and some tests forGenerateConstrainedScansthat have lived inscanfor years.The goal of this change is to make it easier to find tests for a
specific rule and to set a precedent for future tests.
Release note: None