Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xform: reorganize rules and tests for consistency #55654

Merged
merged 2 commits into from
Oct 20, 2020
Merged

xform: reorganize rules and tests for consistency #55654

merged 2 commits into from
Oct 20, 2020

Commits on Oct 19, 2020

  1. xform: organize rules by the type of expressions they match 

    This commit organizes exploration rules by the type of expressions they
match. `GenerateZigzagJoins` and `GenerateInvertedZigzagJoins` have been
moved to `select.opt`. All other rules were correctly organized.

Release note: None
    @mgartner
    mgartner committed Oct 19, 2020
    Configuration menu
    Copy the full SHA
    201ee03 View commit details
    Browse the repository at this point in the history

  2. xform: reorganize tests to match the organization of the rules 

    This commit moves around (and makes some minor necessary changes) to
exploration tests so that tests for rules in `foo.opt` can be found in
`testdata/foo`. Most of the changes were related to zigzag join rules
which moved from `join` to `select`, and some tests for
`GenerateConstrainedScans` that have lived in `scan` for years.

The goal of this change is to make it easier to find tests for a
specific rule and to set a precedent for future tests.

Release note: None
    @mgartner
    mgartner committed Oct 19, 2020
    Configuration menu
    Copy the full SHA
    652ec80 View commit details
    Browse the repository at this point in the history