Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cliccl: add load show backups to display backup collection #61862

Merged
merged 2 commits into from
Mar 15, 2021

Conversation

Elliebababa
Copy link
Contributor

@Elliebababa Elliebababa commented Mar 11, 2021

Previously, users can list backups created by BACKUP INTO
with SHOW BACKUP INin a sql session. But this listing task
can be also done offline without a running cluster.

This PR updates load show with backups subcommand,
which allows users to list backups in a backup collection
created by BACKUP INTO.
With the same purpose as other load show subcommands,
this update allows users to list backups without running
SHOW BACKUP IN in a sql session.

see #61131 #61829 to checkout other load show subcommand.

Release note (cli change): Add load show backups to
display backup collection. Previously, users can list backups
created by BACKUP INTO via SHOW BACKUP INin a sql
session. But this listing task can be also done offline without a
running cluster. Now, users are able to list backups in a collection
with `cockroach load show backups <collection_url>.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@pbardea pbardea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a couple of my comments on the incremental PR also apply here, but mostly nits.

pkg/ccl/cliccl/load.go Show resolved Hide resolved
pkg/ccl/cliccl/load.go Outdated Show resolved Hide resolved
Previously, `load show` only supports showing metadata of a single backup
manifest. Users are ignorant of the incremental backups and have no ways to
inspect the incremental backup manifests unless they know the incremental
paths beforehand.

This PR updates `load show` with `incremental` subcommand to display
incremental backups, i.e. displaying the auto appended incremental backup
paths of a full backup. After listing the incremental paths, users are able to
inspect an incremental backup manifest with `load show summary`.

see cockroachdb#61131

Release note (cli change): Update `load show` with `incremental`
subcommand to display incremental backups. User can list
incremental backup paths of a full backup by running
`cockroach load show incremental <backup_url>.`
Previously, users can list backups created by `BACKUP INTO`
with `SHOW BACKUP IN`in a sql session. But this listing task
can be also done offline without a running cluster.

This PR updates `load show` with `backups` subcommand, which allows
users to list backups in a backup collection created by
`BACKUP INTO`. With the same purpose as other `load
show` subcommands, this update allows users to list backups without
 running `SHOW BACKUP IN` in a sql session.

see cockroachdb#61131 cockroachdb#61829 to checkout other `load show` subcommand.

Release note (cli change): Add `load show backups` to
display backup collection. Previously, users can list backups
created by `BACKUP INTO` via `SHOW BACKUP IN`in a sql
session. But this listing task can be also done
offline without a running cluster. Now, users are able to list
backups in a collection with
`cockroach load show backups <collection_url>.
@Elliebababa Elliebababa marked this pull request as ready for review March 15, 2021 13:36
@Elliebababa Elliebababa requested review from a team and pbardea and removed request for a team March 15, 2021 13:36
Copy link
Contributor

@pbardea pbardea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Second commit LGTM

@Elliebababa
Copy link
Contributor Author

TFTR!

bors r=pbardea

@craig
Copy link
Contributor

craig bot commented Mar 15, 2021

Build succeeded:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants