-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cliccl: add load show backups
to display backup collection
#61862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbardea
reviewed
Mar 12, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a couple of my comments on the incremental PR also apply here, but mostly nits.
Previously, `load show` only supports showing metadata of a single backup manifest. Users are ignorant of the incremental backups and have no ways to inspect the incremental backup manifests unless they know the incremental paths beforehand. This PR updates `load show` with `incremental` subcommand to display incremental backups, i.e. displaying the auto appended incremental backup paths of a full backup. After listing the incremental paths, users are able to inspect an incremental backup manifest with `load show summary`. see cockroachdb#61131 Release note (cli change): Update `load show` with `incremental` subcommand to display incremental backups. User can list incremental backup paths of a full backup by running `cockroach load show incremental <backup_url>.`
Previously, users can list backups created by `BACKUP INTO` with `SHOW BACKUP IN`in a sql session. But this listing task can be also done offline without a running cluster. This PR updates `load show` with `backups` subcommand, which allows users to list backups in a backup collection created by `BACKUP INTO`. With the same purpose as other `load show` subcommands, this update allows users to list backups without running `SHOW BACKUP IN` in a sql session. see cockroachdb#61131 cockroachdb#61829 to checkout other `load show` subcommand. Release note (cli change): Add `load show backups` to display backup collection. Previously, users can list backups created by `BACKUP INTO` via `SHOW BACKUP IN`in a sql session. But this listing task can be also done offline without a running cluster. Now, users are able to list backups in a collection with `cockroach load show backups <collection_url>.
Elliebababa
force-pushed
the
load_show_backups
branch
from
March 12, 2021 23:25
1d92b4f
to
5d3f584
Compare
Elliebababa
requested review from
a team and
pbardea
and removed request for
a team
March 15, 2021 13:36
pbardea
approved these changes
Mar 15, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Second commit LGTM
TFTR! bors r=pbardea |
Build succeeded: |
This was referenced Sep 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, users can list backups created by
BACKUP INTO
with
SHOW BACKUP IN
in a sql session. But this listing taskcan be also done offline without a running cluster.
This PR updates
load show
withbackups
subcommand,which allows users to list backups in a backup collection
created by
BACKUP INTO
.With the same purpose as other
load show
subcommands,this update allows users to list backups without running
SHOW BACKUP IN
in a sql session.see #61131 #61829 to checkout other
load show
subcommand.Release note (cli change): Add
load show backups
todisplay backup collection. Previously, users can list backups
created by
BACKUP INTO
viaSHOW BACKUP IN
in a sqlsession. But this listing task can be also done offline without a
running cluster. Now, users are able to list backups in a collection
with `cockroach load show backups <collection_url>.