cliccl/load: update `load show` with `summary` subcommand to display backup meta information #61131

Elliebababa · 2021-02-25T17:56:22Z

Previously, cockroach load show <backup_path> is used for debugging purposes, and displays all the metadata (including Spans, Files, Descriptors) of a single backup manifest file.

With this PR, we update load show with summary subcommand. Users can inspect metadata of a single manifest by using load show summary <backup_url>. User-defined types and user-defined schemas are added to the output. Also, we add support of "nodelocal://0/" access.

see
#18434
#60790

Release justification: Non-production code changes
Release note (cli change): Update load show with summary subcommand to display information of backup metadata. Users can inspect metadata information of a single manifest by using .cockroach load show summary <backup_url>.

$ ./cockroach load show summary "nodelocal://self/f1"                       
StartTime: 1970-01-01T00:00:00Z (0,0)
EndTime: 2021-02-24T02:14:12.635069Z (1614132852.635069000,0)
DataSize: 15772 (15 KiB)
Rows: 58
IndexEntries: 70
FormatVersion: 1
ClusterID: 171d37c2-0cb1-4f14-af20-5d9a51ccbbf3
NodeID: 0
BuildInfo: CockroachDB CCL v21.1.0-alpha.1-2022-g497a9c01d1 (x86_64-apple-darwin19.6.0, built 2021/02/17 17:23:27, go1.15.7)
Spans:
        /Table/4/{1-2}
        /Table/5/{1-2}
        /Table/6/{1-2}
        /Table/14/{1-2}
        /Table/15/{1-4}
        /Table/21/{1-2}
        /Table/23/{1-4}
        /Table/24/{1-2}
        /Table/33/{1-2}
        /Table/37/{1-3}
        /Table/52/{1-2}
        /Table/75/{1-2}
        /Table/76/{1-2}
        /Table/77/{1-2}
Files:
        635903846438207489.sst:
                Span: /Table/4/{1-2}
                DataSize: 99 (99 B)
                Rows: 2
                IndexEntries: 0
        635903846681772033.sst:
                Span: /Table/5/{1-2}
                DataSize: 282 (282 B)
                Rows: 7
                IndexEntries: 0
        635903846438338561.sst:
                Span: /Table/6/{1-2}
                DataSize: 374 (374 B)
                Rows: 5
                IndexEntries: 0
        635903846605324289.sst:
                Span: /Table/15/{1-4}
                DataSize: 14480 (14 KiB)
                Rows: 34
                IndexEntries: 68
        635903846439354369.sst:
                Span: /Table/21/{1-2}
                DataSize: 261 (261 B)
                Rows: 5
                IndexEntries: 0
        635903846599852033.sst:
                Span: /Table/23/{1-4}
                DataSize: 94 (94 B)
                Rows: 1
                IndexEntries: 2
        635903847072792577.sst:
                Span: /Table/75/{1-2}
                DataSize: 182 (182 B)
                Rows: 4
                IndexEntries: 0
Databases:
        1: system
        50: defaultdb
        51: postgres
Schemas:
        29: public
Types:
        (No user-defined types included in the specified backup path.)
Tables:
        4: system.public.users
        5: system.public.zones
        6: system.public.settings
        14: system.public.ui
        15: system.public.jobs
        21: system.public.locations
        23: system.public.role_members
        24: system.public.comments
        33: system.public.role_options
        37: system.public.scheduled_jobs
        52: defaultdb.public.products
        75: defaultdb.public.customers
        76: defaultdb.public.abc
        77: defaultdb.public.deep_folder

cockroach-teamcity · 2021-02-25T17:56:29Z

This change is

pbardea

Looking good, did a first pass of it. Will go for a more indepth pass later today as well.

Reviewed 1 of 4 files at r1, 1 of 4 files at r4.
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @Elliebababa and @pbardea)

pkg/ccl/cliccl/load.go, line 214 at r1 (raw file):

}

func showDescriptor(desc backupccl.BackupManifest) {

Since this command claims to show all descriptors, we chatted about that we'll probably also want to display things like user defined schemas and types. Is the plan to add those in a follow up PR?

pkg/ccl/cliccl/load.go, line 232 at r1 (raw file):

	}

	fmt.Printf("Tables:\n")

I think listing the descriptors would be interesting, more as a debugging tool. But I think users would be particularly interested in the tables included in the backup. I think that offering a specific cockroach load show tables command that shows the fully qualified name would be nice since the output would be better format to pipe into other command (like potentially reading the data for that table).

This can be added in a follow up.

Listing the tables like:

$ cockroach load show tables <backup_url>
foodb.fooschema.footable
foodb.public.footable2

Should be what the user is really after, especially since the expected use-case of this tool is to see what tables are in the backup, so that they can get access to the data.

pkg/ccl/cliccl/load.go, line 172 at r4 (raw file):

	if _, ok := options[descriptors]; ok {
		err = showDescriptor(desc)
		if err != nil {

nit: just as an FYI, we frequently do:

if err := showDescriptors(desc); err != nil {
    return err
}

With this pattern/

pkg/ccl/cliccl/load.go, line 213 at r4 (raw file):

	for _, f := range desc.Files {
		fmt.Printf("%s%s:\n", tabfmt, f.Path)
		fmt.Printf("	Span: %s\n", f.Span)

Should we be using tabfmt here and below?

pkg/ccl/cliccl/load_test.go, line 56 at r4 (raw file):

	}

	// load show with spans option

nit: We usually format full line comments as full sentences: // Test load show with span optiosn. I think this would be a good candidate for a subtest e.g. t.Run("show-spans", func(t *testing.T) { // test here}.

pkg/ccl/cliccl/load_test.go, line 59 at r4 (raw file):

	out, err = c.RunWithCapture(fmt.Sprintf("load show %s spans --external-io-dir=%s", backupPath, dir))
	require.NoError(t, err)
	expectedSpansOutput :=

I think we can put this output to 1 line.

pkg/ccl/cliccl/load_test.go, line 75 at r4 (raw file):

	out, err = c.RunWithCapture(fmt.Sprintf("load show %s descriptors --external-io-dir=%s", backupPath, dir))
	require.NoError(t, err)
	expectedDescOutput :=

nit: can we unindent the first line of this string all the way for readability?

Elliebababa

Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @pbardea)

pkg/ccl/cliccl/load.go, line 214 at r1 (raw file):

Previously, pbardea (Paul Bardea) wrote…

Since this command claims to show all descriptors, we chatted about that we'll probably also want to display things like user defined schemas and types. Is the plan to add those in a follow up PR?

Yes. It is displaying user-defined schemas now (under the Schemas: in load show descriptors command). Will include types in the same PR.

pkg/ccl/cliccl/load.go, line 232 at r1 (raw file):

Previously, pbardea (Paul Bardea) wrote…

I think listing the descriptors would be interesting, more as a debugging tool. But I think users would be particularly interested in the tables included in the backup. I think that offering a specific cockroach load show tables command that shows the fully qualified name would be nice since the output would be better format to pipe into other command (like potentially reading the data for that table).

This can be added in a follow up.

Listing the tables like:
$ cockroach load show tables <backup_url>
foodb.fooschema.footable
foodb.public.footable2
Should be what the user is really after, especially since the expected use-case of this tool is to see what tables are in the backup, so that they can get access to the data.

Will add it in a follow up PR.

pkg/ccl/cliccl/load.go, line 213 at r4 (raw file):

Previously, pbardea (Paul Bardea) wrote…

Should we be using tabfmt here and below?

Done.

pkg/ccl/cliccl/load_test.go, line 59 at r4 (raw file):

Previously, pbardea (Paul Bardea) wrote…

I think we can put this output to 1 line.

Done.

pbardea

Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @Elliebababa and @pbardea)

pkg/ccl/cliccl/load.go, line 46 at r6 (raw file):

		Short: "show backups summary",
		Long:  "Shows summary of meta information about a SQL backup.",
		Args:  cobra.MinimumNArgs(1),

Should this be cobra.ExactArgs(1)?

pkg/ccl/cliccl/load.go, line 53 at r6 (raw file):

		Use:   "show [command]",
		Short: "show backup information",
		Long:  "Shows subset(s) of information about a SQL backup.",

I think we can keep this as the old description now.

pkg/ccl/cliccl/load.go, line 85 at r6 (raw file):

func newBlobFactory(ctx context.Context, dialing roachpb.NodeID) (blobs.BlobClient, error) {
	if dialing != 0 {
		return nil, errors.Errorf(`only support nodelocal (0/self) under cli inspection`)

nit: The phrasing of this error message is a bit confusing to me. Perhaps something like errors.Errorf(accessing node %d during nodelocal access is unsupported for CLI inspection; only local access is supported with nodelocal://self, dialing)?

pkg/ccl/cliccl/load.go, line 165 at r6 (raw file):

	schemaIDToNameChain := make(map[descpb.ID]string)
	schemaIDToNameChain[keys.PublicSchemaID] = sessiondata.PublicSchemaName
	typeIDs := make([]descpb.ID, 0)

It looks like the slices and maps here are storing the same information? Can we just use the map here?

pkg/ccl/cliccl/load.go, line 186 at r6 (raw file):

			typeIDToNameChain[id] = parentSchema + "." + typeName
			typeIDs = append(typeIDs, id)
		}

We'll still want showDescriptors to show the tables as well I think. I think that users may be interested in showing just the tables as a separate command that we can add in a follow-up, but I think we'll want to keep tables here like we had before.

pkg/ccl/cliccl/load.go, line 202 at r6 (raw file):

	if len(typeIDs) > 0 {
		fmt.Printf("Types:\n")

Let's put the header above the if check to explicitly show that there are no types included in the backup.

pkg/ccl/cliccl/load_test.go, line 59 at r6 (raw file):

		expectedDescOutput := `
Databases:
	52.testdb

I think we should avoid formatting this as id.name since names are partitioned by . (e.g. testdb.public.footype). Let's instead format it as either 52: testdb or testdb (52).

pkg/cli/cli_test.go, line 50 at r6 (raw file):

	skip.UnderShort(t)

	c := NewCliTest(TestCliParams{T: t})

I think I preferred NewCLITest returning a CLITest. I think things get a bit more confusing when renaming the structs to TestCli. The rename is also a separate change from what the commit is achieving, which is exporting the helpers for ccl tests to access.

pkg/cli/doctor_test.go, line 24 at r6 (raw file):

func TestDoctorCluster(t *testing.T) {
	defer leaktest.AfterTest(t)()
	c := NewCliTest(TestCliParams{T: t})

nit: I think the old capitalization of CLI is what we typically do. For acronyms, the later letters usually follow the casing of the first one.

pkg/cli/testutils.go, line 114 at r6 (raw file):

}

// NewCliTest export for cclcli

nit: we usually format comments that are on their own line as full sentences (ie end in a .). Here and the couple of other places in this file.

Previously, `load show` only supports showing metadata of a single backup manifest. Users are ignorant of the incremental backups and have no ways to inspect the incremental backup manifests unless they know the incremental paths beforehand. This PR updates `load show` with `incremental` subcommand to display incremental backups, i.e. displaying the auto appended incremental backup paths of a full backup. After listing the incremental paths, users are able to inspect an incremental backup manifest with `load show summary`. see cockroachdb#61131 Release note (cli change): Update `load show` with `incremental` subcommand to display incremental backups. User can list incremental backup paths of a full backup by running `cockroach load show incremental <backup_url>.`

pbardea

LGTM with a minor comment nit, also tagging @itsbilal to take a look from the CLI side. Note: the load command is currently undocumented and we're cleaning it up. The main thing to review from the CLI side is 5c95fcf.

Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @Elliebababa and @pbardea)

pkg/cli/testutils.go, line 43 at r9 (raw file):

}

// TestCLI represents test for cli.

nit: I think we can say a bit more in this comment, something like: TestCLI wraps a test server and is used by tests to make assertions about the output of CLI commands.

Previously, users can list backups created by `BACKUP INTO` with `SHOW BACKUP IN`in a sql session. But this listing task can be also done offline without a running cluster. This PR updates `load show` with `backups` subcommand, which allows users to list backups in a backup collection created by `BACKUP INTO`. With the same purpose as other `load show` subcommands, this update allows users to list backups without running `SHOW BACKUP IN` in a sql session. see cockroachdb#61131 cockroachdb#61829 to checkout other `load show` subcommand. Release note (cli change): Add `load show backups` to display backup collection. Previously, users can list backups created by `BACKUP INTO` via `SHOW BACKUP IN`in a sql session. But this listing task can be also done offline without a running cluster. Now, users are able to list backups in a collection with `cockroach load show backups <collection_url>.

itsbilal

5c96fcf looks good to me! I've left some comments but they're mostly just about style / struct naming that should be fairly easy to fix. Good work!

Reviewed 16 of 16 files at r8.
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @Elliebababa, @itsbilal, and @pbardea)

pkg/ccl/cliccl/load.go, line 223 at r8 (raw file):

	// Note that these descriptors could be from any past version of the cluster,
	// in case more fields need to be added to the output.
	dbIDs := make([]descpb.ID, 0)

Nit: You can save some repeat allocations by passing a capacity like dbIDs := make([]descpb.ID, 0, len(desc.Descriptors)). It's okay if it's larger than what it ends up being.

pkg/ccl/cliccl/load_test.go, line 41 at r8 (raw file):

	sqlDB := sqlutils.MakeSQLRunner(db)
	sqlDB.Exec(t, `CREATE DATABASE testDB`)

Probably a good idea to throw a require.NoError around these Execs.

pkg/cli/testutils.go, line 44 at r8 (raw file):

// TestCLI represents test for cli
type TestCLI struct {

I see Paul alluded to this earlier, but can we go with calling this CLITest (and the params struct CLITestParams) instead? That way it's both more consistent with the existing code, and leads to less confusion / naming conflicts with functions named TestCLI* that are actual test functions. I don't feel very strongly about this so if y'all have agreed to go with this for some reason, feel free to ignore this little point.

Elliebababa

Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @itsbilal and @pbardea)

pkg/ccl/cliccl/load.go, line 46 at r6 (raw file):

Previously, pbardea (Paul Bardea) wrote…

Should this be cobra.ExactArgs(1)?

Done.

pkg/ccl/cliccl/load.go, line 53 at r6 (raw file):

Previously, pbardea (Paul Bardea) wrote…

I think we can keep this as the old description now.

Done.

pkg/ccl/cliccl/load.go, line 165 at r6 (raw file):

Previously, pbardea (Paul Bardea) wrote…

It looks like the slices and maps here are storing the same information? Can we just use the map here?

Note: the slices are used to keep descriptors sorted by IDs. We can remove it once we found sorting descriptors is not necessarily needed.

pkg/ccl/cliccl/load.go, line 186 at r6 (raw file):

Previously, pbardea (Paul Bardea) wrote…

We'll still want showDescriptors to show the tables as well I think. I think that users may be interested in showing just the tables as a separate command that we can add in a follow-up, but I think we'll want to keep tables here like we had before.

Done.

pkg/ccl/cliccl/load.go, line 202 at r6 (raw file):

Previously, pbardea (Paul Bardea) wrote…

Let's put the header above the if check to explicitly show that there are no types included in the backup.

Done.

pkg/ccl/cliccl/load.go, line 223 at r8 (raw file):

Previously, itsbilal (Bilal Akhtar) wrote…

Nit: You can save some repeat allocations by passing a capacity like dbIDs := make([]descpb.ID, 0, len(desc.Descriptors)). It's okay if it's larger than what it ends up being.

Done

pkg/ccl/cliccl/load_test.go, line 59 at r6 (raw file):

Previously, pbardea (Paul Bardea) wrote…

I think we should avoid formatting this as id.name since names are partitioned by . (e.g. testdb.public.footype). Let's instead format it as either 52: testdb or testdb (52).

Done.

pkg/ccl/cliccl/load_test.go, line 41 at r8 (raw file):

Previously, itsbilal (Bilal Akhtar) wrote…

Probably a good idea to throw a require.NoError around these Execs.

SQLRunner exec comment says:'Exec is a wrapper around gosql.Exec that kills the test on error'. If I didn't get it wrong, the error will be catched by running sqlDB.Exec (I tried, it did). But if I missed something else, please correct me :)

pkg/cli/cli_test.go, line 50 at r6 (raw file):

Previously, pbardea (Paul Bardea) wrote…

I think I preferred NewCLITest returning a CLITest. I think things get a bit more confusing when renaming the structs to TestCli. The rename is also a separate change from what the commit is achieving, which is exporting the helpers for ccl tests to access.

Note: cliTest is renamed to TestCLI to pass linter check.

pkg/cli/testutils.go, line 44 at r8 (raw file):

Previously, itsbilal (Bilal Akhtar) wrote…

I see Paul alluded to this earlier, but can we go with calling this CLITest (and the params struct CLITestParams) instead? That way it's both more consistent with the existing code, and leads to less confusion / naming conflicts with functions named TestCLI* that are actual test functions. I don't feel very strongly about this so if y'all have agreed to go with this for some reason, feel free to ignore this little point.

I tried CLITest and CLITestParams, but given that those exported structs are in cli pkg, struct names starting with 'CLI..' is failing by the linter. If you got other thoughts about the naming, I will follow up with this :)

Previously, `cockroach load show <backup_path>` is used for debugging purposes, and displays all the metadata of a single backup manifest file. With this PR, we extend `load show` with more options to display subset of data. Also, we add support of "nodelocal://0/" access. Release justification: Non-production code changes Release note (cli change): Add `load show` args to display subset of backup metadata. Users can display subsets of metadata of a single manifest by using `load show files/descriptors/metadata/spans <backup_url>`.

Previously, clitest only has private access within cli package, while cliccl lack sufficient tests for ccl cli tools. With this commit, clitest utils are exported for cliccl and cliccl can reuse them for unit tests. The `cliTest` struct and the `cliTestParams` struct are renamed as `TestCLI` and `TestCLIParams`. Release justification: Low risk, high benefit changes to existing functionality. Release note: None

Previously, `load show` provides different options to display subset of meta information of backup, but the option parsing could be error prone and prefer a better way to provide users with subset options(e.g.with --include). This commit updates `load show` with `summary` subcommand to display all metadata of an individual backup for debugging. Release justification: non-production code changes. Release note (cli change): Update `load show` with `summary` subcommand to display meta information of an individual backup. Users are now able to inspect backup metadata, files, spans and descriptors with cli command `cockroach load show summary <backup_url>` without a running cluster.

pbardea

LGTM, I think this is good to merge!

Elliebababa · 2021-03-12T15:43:58Z

TFTR!
bors r=pbardea,itsbilal

craig · 2021-03-12T16:15:03Z

Build succeeded:

GitHub CI (Cockroach)

Previously, `load show` only supports showing metadata of a single backup manifest. Users are ignorant of the incremental backups and have no ways to inspect the incremental backup manifests unless they know the incremental paths beforehand. This PR updates `load show` with `incremental` subcommand to display incremental backups, i.e. displaying the auto appended incremental backup paths of a full backup. After listing the incremental paths, users are able to inspect an incremental backup manifest with `load show summary`. see cockroachdb#61131 Release note (cli change): Update `load show` with `incremental` subcommand to display incremental backups. User can list incremental backup paths of a full backup by running `cockroach load show incremental <backup_url>.`

Previously, users can list backups created by `BACKUP INTO` with `SHOW BACKUP IN`in a sql session. But this listing task can be also done offline without a running cluster. This PR updates `load show` with `backups` subcommand, which allows users to list backups in a backup collection created by `BACKUP INTO`. With the same purpose as other `load show` subcommands, this update allows users to list backups without running `SHOW BACKUP IN` in a sql session. see cockroachdb#61131 cockroachdb#61829 to checkout other `load show` subcommand. Release note (cli change): Add `load show backups` to display backup collection. Previously, users can list backups created by `BACKUP INTO` via `SHOW BACKUP IN`in a sql session. But this listing task can be also done offline without a running cluster. Now, users are able to list backups in a collection with `cockroach load show backups <collection_url>.

61406: sql: validate against array type usages when dropping enum values r=ajwerner a=arulajmani Previously, when dropping an enum value, we weren't validating if the enum value was used in a column of array type. This patch fixes the bug. Fixes #60004 Release justification: bug fix to new functionality Release note: None 61650: roachtest: exclude `lost+found` directory r=knz a=rickystewart This directory is created by the filesystem and unowned file chunks are put there by `fsck`. The directory and its contents aren't readable by anyone except `root`, so this can cause the `du -c /mnt/data1` that `roachtest` performs to fail -- add an `--exclude` to handle this. We already ignore this directory in other contexts (for example, see `pkg/storage/mvcc.go`). Fixes #53663. Release justification: Non-production code change Release note: None 61788: importccl: unskip userfile benchmark r=pbardea a=adityamaru I've run this ~20 times and it averages ~13s to run. I suspect the fixes to linked issues mentioned in #59126 might have mitigated this. Going to unskip due to lack of reproducibility. Fixes: #59126 Release note: None 61828: contention: store contention events on non-SQL keys r=yuzefovich a=yuzefovich Previously, whenever we tried to add a contention event on a non-SQL key, it would encounter an error during decoding tableID/indexID pair, and the event was dropped. This commit extends the contention registry to additionally store information about contention on non-SQL keys. That information is stored in two levels: - on the top level, all `SingleNonSQLKeyContention` objects are ordered by their keys - on the bottom level, all `SingleTxnContention` objects are ordered by the number of times that transaction was observed to contend with other transactions. `SingleTxnContention` protobuf message is moved out of `SingleKeyContention` and is reused for non-SQL keys. This commit also updates the status server API response. I assume that no changes are needed with regards to backwards compatibility since the original version was merged just a few weeks ago, and we haven't had a beta released since then. Fixes: #60669. Release note (sql change): CockroachDB now also stores the information about contention on non-SQL keys. 61862: cliccl: add `load show backups` to display backup collection r=pbardea a=Elliebababa Previously, users can list backups created by `BACKUP INTO` with `SHOW BACKUP IN`in a sql session. But this listing task can be also done offline without a running cluster. This PR updates `load show` with `backups` subcommand, which allows users to list backups in a backup collection created by `BACKUP INTO`. With the same purpose as other `load show` subcommands, this update allows users to list backups without running `SHOW BACKUP IN` in a sql session. see #61131 #61829 to checkout other `load show` subcommand. Release note (cli change): Add `load show backups` to display backup collection. Previously, users can list backups created by `BACKUP INTO` via `SHOW BACKUP IN`in a sql session. But this listing task can be also done offline without a running cluster. Now, users are able to list backups in a collection with `cockroach load show backups <collection_url>. 61877: bench/ddl_analysis: fix test for real r=ajwerner a=ajwerner See individual commits. Last is the critical one. Fixes #61856. 61937: colexec: make vectorized stats concurrency safe r=yuzefovich a=yuzefovich **colflow: clean up vectorized stats for rowexec processors** Previously, the wrapped row-execution KV reading processors were implementing `execinfra.KVReader` interface, but they were never used as such, only the ColBatchScans would get used to retrieve the KV stats. This is the case because the row-execution processors report their execution stats themselves, and we don't want to duplicate that info. This commit moves `KVReader` interface into `colexecop` package and now only the ColBatchScans implement it. This allowed for some cleanup around the vectorized stats code, but the main reason for performing this change is that the contract of the interface will be modified by the follow-up commit to mention the safety under concurrent usage, and I didn't want to change the row-execution processors for that since the relevant methods never get called anyway. Additionally, this commit begins emitting of rows-read and bytes-read by the zigzagJoiners and invertedJoiners to complete the metrics picture. Release note: None **colexec: make vectorized stats concurrency safe** Previously, the collection of vectorized stats was not synchronized with the operators themselves. Namely, it was possible to call methods like `GetBytesRead` on the ColBatchScans and Inboxes from a different goroutine (the root materializer or the outbox) than from the main goroutine of the operator. This is now fixed by putting mutexes in place and updating `colexecop.KVReader` interface to require concurrency-safe implementations. Fixes: #61899. Release note: None Co-authored-by: arulajmani <arulajmani@gmail.com> Co-authored-by: Ricky Stewart <ricky@cockroachlabs.com> Co-authored-by: Aditya Maru <adityamaru@gmail.com> Co-authored-by: Yahor Yuzefovich <yahor@cockroachlabs.com> Co-authored-by: elliebababa <ellie24.huang@gmail.com> Co-authored-by: Andrew Werner <awerner32@gmail.com>

Elliebababa force-pushed the add_load_option branch 3 times, most recently from 7f5072d to a3d6a63 Compare February 25, 2021 21:38

Elliebababa changed the title ~~[WIP] cliccl/load: Add load show args to display subset of backup metadata~~ [WIP] cliccl/load: add load show args to display subset of backup metadata Feb 25, 2021

Elliebababa marked this pull request as draft March 1, 2021 19:56

Elliebababa force-pushed the add_load_option branch 14 times, most recently from e5a4de7 to ffc78bf Compare March 5, 2021 21:44

Elliebababa changed the title ~~[WIP] cliccl/load: add load show args to display subset of backup metadata~~ cliccl/load: add load show args to display subset of backup metadata Mar 5, 2021

Elliebababa marked this pull request as ready for review March 5, 2021 23:00

Elliebababa requested a review from a team as a code owner March 5, 2021 23:00

Elliebababa requested a review from pbardea March 5, 2021 23:00

pbardea reviewed Mar 8, 2021

View reviewed changes

pbardea self-requested a review March 8, 2021 15:18

Elliebababa commented Mar 8, 2021

View reviewed changes

Elliebababa force-pushed the add_load_option branch from ffc78bf to b6f00f3 Compare March 8, 2021 20:59

pbardea reviewed Mar 9, 2021

View reviewed changes

Elliebababa force-pushed the add_load_option branch from e71331d to d5207e2 Compare March 9, 2021 22:02

Elliebababa force-pushed the add_load_option branch from d8b2acd to f33e921 Compare March 10, 2021 06:34

Elliebababa requested a review from pbardea March 10, 2021 14:25

Elliebababa mentioned this pull request Mar 11, 2021

cliccl: add load show subcommand incremental to display incremental backups #61829

Merged

pbardea approved these changes Mar 11, 2021

View reviewed changes

pbardea requested review from pbardea and itsbilal March 11, 2021 17:56

Elliebababa mentioned this pull request Mar 11, 2021

cliccl: add load show backups to display backup collection #61862

Merged

itsbilal approved these changes Mar 11, 2021

View reviewed changes

Elliebababa force-pushed the add_load_option branch from f33e921 to 9f6b7a0 Compare March 11, 2021 23:52

Elliebababa commented Mar 11, 2021

View reviewed changes

Elliebababa added 3 commits March 11, 2021 16:39

Elliebababa force-pushed the add_load_option branch from 9f6b7a0 to aa7238a Compare March 12, 2021 01:58

pbardea approved these changes Mar 12, 2021

View reviewed changes

craig bot merged commit e7f33b7 into cockroachdb:master Mar 12, 2021

This was referenced Sep 8, 2021

cliccl/load: update load show with summary subcommand to display backup meta information cockroachdb/docs#11491

Closed

cliccl/load: update load show with summary subcommand to display backup meta information cockroachdb/docs#11492

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

cliccl/load: update `load show` with `summary` subcommand to display backup meta information #61131

cliccl/load: update `load show` with `summary` subcommand to display backup meta information #61131

Elliebababa commented Feb 25, 2021 •

edited

Loading

cockroach-teamcity commented Feb 25, 2021

pbardea left a comment

Elliebababa left a comment

pbardea left a comment

pbardea left a comment

itsbilal left a comment

Elliebababa left a comment

pbardea left a comment

Elliebababa commented Mar 12, 2021

craig bot commented Mar 12, 2021

cliccl/load: update load show with summary subcommand to display backup meta information #61131

cliccl/load: update load show with summary subcommand to display backup meta information #61131

Conversation

Elliebababa commented Feb 25, 2021 • edited Loading

cockroach-teamcity commented Feb 25, 2021

pbardea left a comment

Choose a reason for hiding this comment

Elliebababa left a comment

Choose a reason for hiding this comment

pbardea left a comment

Choose a reason for hiding this comment

pbardea left a comment

Choose a reason for hiding this comment

itsbilal left a comment

Choose a reason for hiding this comment

Elliebababa left a comment

Choose a reason for hiding this comment

pbardea left a comment

Choose a reason for hiding this comment

Elliebababa commented Mar 12, 2021

craig bot commented Mar 12, 2021

cliccl/load: update `load show` with `summary` subcommand to display backup meta information #61131

cliccl/load: update `load show` with `summary` subcommand to display backup meta information #61131

Elliebababa commented Feb 25, 2021 •

edited

Loading