sql: ALTER TYPE ... DROP VALUE doesn't account for array type usages

[arulajmani]

Describe the problem

Currently, when validating wether an enum value can be dropped or not, we don't validate using the Array type descriptor.

To Reproduce

demo@127.0.0.1:26257/movr> CREATE TYPE abc AS ENUM('a', 'b', 'c');
CREATE TYPE

Time: 4ms total (execution 4ms / network 0ms)

demo@127.0.0.1:26257/movr> CREATE TABLE a(k INT, v abc[]);
CREATE TABLE

Time: 31ms total (execution 7ms / network 23ms)

demo@127.0.0.1:26257/movr> INSERT INTO a VALUES (1, ARRAY['a']);
INSERT 1

Time: 5ms total (execution 5ms / network 0ms)

demo@127.0.0.1:26257/movr> ALTER TYPE abc DROP VALUE 'a';
ALTER TYPE

Time: 41ms total (execution 4ms / network 37ms)

demo@127.0.0.1:26257/movr> SELECT * FROM a; ;
ERROR: internal error: unexpected error from the vectorized engine: could not find [64] in enum "public.abc" representation PhysicalReps: [[128] [192]]; LogicalReps: [b c]
SQLSTATE: XX000
DETAIL: stack trace:
github.com/cockroachdb/cockroach/pkg/sql/colexecbase/colexecerror/error.go:90: func1()
runtime/panic.go:969: gopanic()
github.com/cockroachdb/cockroach/pkg/sql/colexecbase/colexecerror/error.go:178: InternalError()
github.com/cockroachdb/cockroach/pkg/sql/colfetcher/colbatch_scan.go:85: Next()
github.com/cockroachdb/cockroach/pkg/sql/colexec/cancel_checker.go:48: Next()
github.com/cockroachdb/cockroach/pkg/sql/colexec/simple_project.go:124: Next()
github.com/cockroachdb/cockroach/pkg/sql/colexec/materializer.go:254: next()
github.com/cockroachdb/cockroach/pkg/sql/colexec/materializer.go:279: nextAdapter()
github.com/cockroachdb/cockroach/pkg/sql/colexecbase/colexecerror/error.go:93: CatchVectorizedRuntimeError()
github.com/cockroachdb/cockroach/pkg/sql/colexec/materializer.go:285: Next()
github.com/cockroachdb/cockroach/pkg/sql/execinfra/base.go:171: Run()
github.com/cockroachdb/cockroach/pkg/sql/execinfra/processorsbase.go:765: Run()
github.com/cockroachdb/cockroach/pkg/sql/flowinfra/flow.go:383: Run()
github.com/cockroachdb/cockroach/pkg/sql/distsql_running.go:366: Run()
github.com/cockroachdb/cockroach/pkg/sql/distsql_running.go:972: PlanAndRun()
github.com/cockroachdb/cockroach/pkg/sql/conn_executor_exec.go:1035: execWithDistSQLEngine()
github.com/cockroachdb/cockroach/pkg/sql/conn_executor_exec.go:907: dispatchToExecutionEngine()
github.com/cockroachdb/cockroach/pkg/sql/conn_executor_exec.go:653: execStmtInOpenState()
github.com/cockroachdb/cockroach/pkg/sql/conn_executor_exec.go:121: execStmt()
github.com/cockroachdb/cockroach/pkg/sql/conn_executor.go:1474: func1()
github.com/cockroachdb/cockroach/pkg/sql/conn_executor.go:1476: execCmd()
github.com/cockroachdb/cockroach/pkg/sql/conn_executor.go:1401: run()
github.com/cockroachdb/cockroach/pkg/sql/conn_executor.go:490: ServeConn()
github.com/cockroachdb/cockroach/pkg/sql/pgwire/conn.go:627: func1()
runtime/asm_amd64.s:1374: goexit()

HINT: You have encountered an unexpected error.

Expected behavior
Drop should fail as the enum value is used inside of an array.