release-21.1: sql: remove fake index and statistics collectors pg_catalog tables #61876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release note (sql change): Remove pg_catalog tables that were mistakenly added, notably all tables that end in _index that are not pg_catalog.pg_classes and all statistics collector tables that are not pg_stat_activity.
|
This change is |
rafiss
approved these changes
Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #61794.
/cc @cockroachdb/release
Release note (sql change): Remove pg_catalog tables that were mistakenly added,
notably all tables that end in _index that are not pg_catalog.pg_classes and all
statistics collector tables that are not pg_stat_activity.
Removing pg statistics collector tables since they are somewhat different from regular pg_catalog tables and it's unlikely for us to implement them. Accessing them will simply error.
pg_metadata_test.gohas not yet been updating to reflect that the _index tables should not actually be tables.Release justification: Low risk, removing unused/unimplemented vtables before they make it into prod.