sql: add interleaved_indexes/interleaved_tables into crdb_internal #62076
Conversation
|
This change is |
There was a problem hiding this comment.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @fqazi)
pkg/sql/crdb_internal.go, line 4235 at r1 (raw file):
tree.NewDString(parentSchemaName), tree.NewDString(table.GetName()), tree.NewDString(parentTable.GetName())); err != nil {
shouldn't we post the parent's schema and database too?
There was a problem hiding this comment.
Reviewable status:
pkg/sql/crdb_internal.go, line 4235 at r1 (raw file):
Previously, ajwerner wrote…
shouldn't we post the parent's schema and database too?
Done. That was silly, I had it in my original changes but forgot it for some reason.
There was a problem hiding this comment.
I think the case we're now not covering well is the case where a secondary index is interleaved into another table, especially one in a different schema. This makes me think we need the database and schema on both tables. I feel like we're coming around full circle...
andrew@free-tier.gcp-us-central1.crdb.io:26257/defaultdb> CREATE TABLE parent (k STRING PRIMARY KEY);
CREATE TABLE
Time: 30ms total (execution 27ms / network 3ms)
andrew@free-tier.gcp-us-central1.crdb.io:26257/defaultdb> CREATE SCHEMA child_schema;
CREATE SCHEMA
Time: 159ms total (execution 29ms / network 130ms)
andrew@free-tier.gcp-us-central1.crdb.io:26257/defaultdb> CREATE TABLE child_schema.child (ck INT PRIMARY KEY, k STRING UNIQUENOT NULL
CREATE TABLE
Time: 392ms total (execution 69ms / network 323ms)
andrew@free-tier.gcp-us-central1.crdb.io:26257/defaultdb> CREATE INDEX interl ON child_schema.child (k) INTERLEAVE IN PARENT pa
rent(k);
CREATE INDEX
Time: 749ms total (execution 93ms / network 656ms)
Reviewed 1 of 10 files at r1, 1 of 3 files at r2.
Reviewable status:
fqazi
force-pushed
the
InterleavedTbl
branch
2 times, most recently
from
3875a5b
to
28da19e
Compare
Previous, when we added the crdb_internal.interleaved table that showed all interleaved indexes, however it was impossible tell which table the primary key of the parent table was interleaved. This was inadequate because users could not tell what the parent table was. To address this, this patch modifies crdb_internal.interleaved to add a parent_table_name column replacing the parent_index one, since that column could only be the primary key. Release note (sql change): Updated crdb_internal.interleaved to add the parent_table_name column replacing the parent_index_name column.
There was a problem hiding this comment.
Reviewed 8 of 10 files at r3.
Reviewable status:
|
bors r=ajwerner |
|
Build succeeded: |
Previous, when we added the crdb_internal.interleaved table that
showed all interleaved indexes, however it was impossible tell
which table the primary key of the parent table was interleaved.
This was inadequate because users could not tell what the parent
table was. To address this, this patch removes
crdb_internal.interleaved and converts it into two virtual tables
interlaved_indexes/interleaved_tables where the one is for
non-primary key indexes and the second is for tables interleaved
on the primary key.
Release note (sql change): Renamed crdb_internal.interleaved to
crdb_internal.interlaved_indexes and added crdb_internal.interlaved_table
for viewing interleaved tables on the primary key.