server, security: Fix one-way connectivity with connect cmd #63589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
knz
approved these changes
Apr 14, 2021
There was a problem hiding this comment.
The change looks deceptively simple but the test suite is trying to tell you something now.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @aaron-crl)
Previously, non-trust-leader nodes couldn't connect back to the trust leader due to the presence of the wrong `ca-client.crt` on their disk; the main CA cert/key was being written in four places. This change fixes that bug, and also creates a new `client.node.crt` certificate to prevent other subsequent errors from being thrown. Fixes cockroachdb#61624. Release note: None.
itsbilal
force-pushed
the
tls-one-way-fix
branch
from
4b8e171
to
60dba10
Compare
|
Fixed the tests - they were testing for the old setup of things. PTAL. |
knz
approved these changes
Apr 19, 2021
There was a problem hiding this comment.
Reviewed 3 of 3 files at r2.
Reviewable status:
|
I'm going to go ahead and merge this since I'd like to use it in follow-up work. bors r+ |
knz
added a commit
to knz/cockroach
that referenced
this pull request
Apr 19, 2021
…nnect` The end-to-end test for the new `connect` command was incomplete, because of issue cockroachdb#61624 that was blocking the functionality. Now that cockroachdb#63589 is in, we can add the missing test. Release note: None
|
Build failed: |
|
Flake: #63844 |
|
flaking test is fixed bors r+ |
|
Build succeeded: |
knz
added a commit
to knz/cockroach
that referenced
this pull request
Apr 19, 2021
…nnect` The end-to-end test for the new `connect` command was incomplete, because of issue cockroachdb#61624 that was blocking the functionality. Now that cockroachdb#63589 is in, we can add the missing test. Release note: None
craig bot
pushed a commit
that referenced
this pull request
Apr 20, 2021
63846: cli/interactive_tests: complete the end-to-end test for `cockroach connect` r=itsbilal a=knz The end-to-end test for the new `connect` command was incomplete, because of issue #61624 that was blocking the functionality. Now that #63589 is in, we can add the missing test. Release note: None 63921: schemaexpr: fix data race in ProcessColumnSet r=adityamaru a=postamar This commit fixes a data race introduced by my recent changes tracked under #63755, involving the generalized use of catalog.Column instead of descpb.ColumnDescriptor. Fixes #63907 Release note: None Co-authored-by: Raphael 'kena' Poss <knz@thaumogen.net> Co-authored-by: Marius Posta <marius@cockroachlabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Informs #60632.
Previously, non-trust-leader nodes couldn't connect back
to the trust leader due to the presence of the wrong
ca-client.crton their disk; the main CA cert/key wasbeing written in four places.
This change fixes that bug,
and also creates a new
client.node.crtcertificate to preventother subsequent errors from being thrown.
Fixes #61624.
Release note: None.