Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-21.1: workload/schemachange: "fix" workload #67597

Closed
wants to merge 20 commits into from

Conversation

ajstorm
Copy link
Collaborator

@ajstorm ajstorm commented Jul 14, 2021

NOTE: These are testing-only changes, to get the schemachange workload in a better place on 21.1.

Backport 20/20 commits from #59635.

/cc @cockroachdb/release


This is a variety of commits which fixes bugs in the schemachange workload. It also disables a number of features.

ajwerner and others added 20 commits July 14, 2021 09:02
Before this we would end up swallowing errors needed by the higher layers
like transaction restarts.

Release note: None
We used to expect `DROP TABLE ... RESTRICT` to fail when the table was
involved in an FK relation. It's fine.

Release note: None
We don't allow dropping it in this case.

Release note: None
Before this commit we'd only look at the previous operation, not all
previous operations. This became a problem when validation was added.

Release note: None
Transaction restart errors must be rolled all the way back. Not doing that
means the workload totally fails. Also, we want to treat uncategorized errors
in generation as a real problem.

Release note: None
Could cause an error which was previously being swallowed.

Release note: None
Fixed by cockroachdb#59565.

Release justification: Testing only.

Release note: None
We currently return an error indicating that this is unsupported.

Release justification: non-production code changes

Release note: None
These all should be re-enabled but they current have problems.

Release note: None
@ajstorm ajstorm requested review from ajwerner and a team July 14, 2021 13:08
@blathers-crl
Copy link

blathers-crl bot commented Jul 14, 2021

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@ajstorm
Copy link
Collaborator Author

ajstorm commented Jul 14, 2021

Upon reflection, not with the risk in backporting.

@ajstorm ajstorm closed this Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants