-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-21.1: workload/schemachange: "fix" workload #67597
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this we would end up swallowing errors needed by the higher layers like transaction restarts. Release note: None
…luster Release note: None
Release note: None
We used to expect `DROP TABLE ... RESTRICT` to fail when the table was involved in an FK relation. It's fine. Release note: None
We don't allow dropping it in this case. Release note: None
… added Release note: None
…ists Release note: None
Before this commit we'd only look at the previous operation, not all previous operations. This became a problem when validation was added. Release note: None
Transaction restart errors must be rolled all the way back. Not doing that means the workload totally fails. Also, we want to treat uncategorized errors in generation as a real problem. Release note: None
Could cause an error which was previously being swallowed. Release note: None
Release note: None
…a name Release note: None
Release note: None
Release note: None
Fixed by cockroachdb#59565. Release justification: Testing only. Release note: None
Release note: None
We currently return an error indicating that this is unsupported. Release justification: non-production code changes Release note: None
Release note: None
Release note: None
These all should be re-enabled but they current have problems. Release note: None
Thanks for opening a backport. Please check the backport criteria before merging:
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
Add a brief release justification to the body of your PR to justify this backport. Some other things to consider:
|
Upon reflection, not with the risk in backporting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: These are testing-only changes, to get the schemachange workload in a better place on 21.1.
Backport 20/20 commits from #59635.
/cc @cockroachdb/release
This is a variety of commits which fixes bugs in the schemachange workload. It also disables a number of features.