Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-21.1: workload/schemachange: "fix" workload #67597

Closed
wants to merge 20 commits into from
Closed

release-21.1: workload/schemachange: "fix" workload #67597

wants to merge 20 commits into from

Commits on Jul 14, 2021

  1. sql: wrap error correctly in drop view 

    Before this we would end up swallowing errors needed by the higher layers
like transaction restarts.

Release note: None
    @ajwerner @ajstorm
    ajwerner authored and ajstorm committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    b691e7a View commit details
    Browse the repository at this point in the history

  2. workload/schemachange: add a test to run the workload against a testc… 

    …luster

Release note: None
    @ajwerner @ajstorm
    ajwerner authored and ajstorm committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    6b0c075 View commit details
    Browse the repository at this point in the history

  3. workload/schemachange: extend test to have concurrency 

    Release note: None
    @ajwerner @ajstorm
    ajwerner authored and ajstorm committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    523fca7 View commit details
    Browse the repository at this point in the history

  4. workload/schemachange: properly detect that self-references are ok 

    We used to expect `DROP TABLE ... RESTRICT` to fail when the table was
involved in an FK relation. It's fine.

Release note: None
    @ajwerner @ajstorm
    ajwerner authored and ajstorm committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    6b59554 View commit details
    Browse the repository at this point in the history

  5. workload/schemachange: detect when a column is part of an index mutation 

    We don't allow dropping it in this case.

Release note: None
    @ajwerner @ajstorm
    ajwerner authored and ajstorm committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    7bdc18e View commit details
    Browse the repository at this point in the history

  6. workload/schemachange: detect not null constraints being concurrently… 

    … added

Release note: None
    @ajwerner @ajstorm
    ajwerner authored and ajstorm committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    74201be View commit details
    Browse the repository at this point in the history

  7. workload/schemachange: don't expect errors if the sequence already ex… 

    …ists

Release note: None
    @ajwerner @ajstorm
    ajwerner authored and ajstorm committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    d31d06f View commit details
    Browse the repository at this point in the history

  8. workload/schemachange: properly detect writes preceding DDLs 

    Before this commit we'd only look at the previous operation, not all
previous operations. This became a problem when validation was added.

Release note: None
    @ajwerner @ajstorm
    ajwerner authored and ajstorm committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    cd3b150 View commit details
    Browse the repository at this point in the history

  9. workload/schemachange: stop swallowing all errors during op generation 

    Transaction restart errors must be rolled all the way back. Not doing that
means the workload totally fails. Also, we want to treat uncategorized errors
in generation as a real problem.

Release note: None
    @ajwerner @ajstorm
    ajwerner authored and ajstorm committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    58290a7 View commit details
    Browse the repository at this point in the history

  10. workload/schemachange: deal with columns not existing in check 

    Could cause an error which was previously being swallowed.

Release note: None
    @ajwerner @ajstorm
    ajwerner authored and ajstorm committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    0f41850 View commit details
    Browse the repository at this point in the history

  11. workload/schemachange: only check if a table has rows if it exists 

    Release note: None
    @ajwerner @ajstorm
    ajwerner authored and ajstorm committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    e3363a9 View commit details
    Browse the repository at this point in the history

  12. workload/schemachange: fix broken query that was not scanning a schem… 

    …a name

Release note: None
    @ajwerner @ajstorm
    ajwerner authored and ajstorm committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    50e75ad View commit details
    Browse the repository at this point in the history

  13. workload/schemachange: detect schemas with cross-schema type references 

    Release note: None
    @ajwerner @ajstorm
    ajwerner authored and ajstorm committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    d2d4443 View commit details
    Browse the repository at this point in the history

  14. workload/schemachange: wrap errors for easier debugging 

    Release note: None
    @ajwerner @ajstorm
    ajwerner authored and ajstorm committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    bfa28a7 View commit details
    Browse the repository at this point in the history

  15. workload/schemachange: add support for multi-column inverted indexes 

    Fixed by cockroachdb#59565.

Release justification: Testing only.

Release note: None
    @ajwerner @ajstorm
    ajwerner authored and ajstorm committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    654f1e0 View commit details
    Browse the repository at this point in the history

  16. workload/schemachange: fix locking bug when an error is encountered 

    Release note: None
    @ajwerner @ajstorm
    ajwerner authored and ajstorm committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    74a6dd8 View commit details
    Browse the repository at this point in the history

  17. workload/schemachange: detect when a constraint is being dropped 

    We currently return an error indicating that this is unsupported.

Release justification: non-production code changes

Release note: None
    @ajwerner @ajstorm
    ajwerner authored and ajstorm committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    43777c7 View commit details
    Browse the repository at this point in the history

  18. workload/schemachange: detect virtual computed columns 

    Release note: None
    @ajwerner @ajstorm
    ajwerner authored and ajstorm committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    fad579e View commit details
    Browse the repository at this point in the history

  19. workload/schemachange: partial work to support insert row 

    Release note: None
    @ajwerner @ajstorm
    ajwerner authored and ajstorm committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    f2a11d1 View commit details
    Browse the repository at this point in the history

  20. workload/schemachange: disable operations which do not currently work 

    These all should be re-enabled but they current have problems.

Release note: None
    @ajwerner @ajstorm
    ajwerner authored and ajstorm committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    f299b37 View commit details
    Browse the repository at this point in the history