sql: clean up some dependencies #79485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
yuzefovich
force-pushed
the
deps
branch
2 times, most recently
from
3ee8583 to
7ad6aaa
Compare
This allows us to break dependency of `execinfra` on `row` which speeds up the build a bit. Release note: None
This commit moves `colexecbase.BinaryOverloadHelper` into `colexecutils` package in order to break the dependencies of `colexecproj` and `colexecprojconst` packages on `colexecbase`. This will speed up the build a bit. Release note: None
msirek
approved these changes
Apr 8, 2022
There was a problem hiding this comment.
Looking forward to faster builds!
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @michae2)
|
I'm looking forward to that glorious future too 🤞 TFTR! bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
row: move Metrics struct into rowinfra
This allows us to break dependency of
execinfraonrowwhich speedsup the build a bit.
Release note: None
colexecbase: move a single struct to clean up dependencies
This commit moves
colexecbase.BinaryOverloadHelperintocolexecutilspackage in order to break the dependencies of
colexecprojandcolexecprojconstpackages oncolexecbase. This will speed up thebuild a bit.
Addresses: #79357.
Release note: None