Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: upgrade to go 1.19.1 #86049

Merged
merged 1 commit into from
Sep 7, 2022
Merged

*: upgrade to go 1.19.1 #86049

merged 1 commit into from
Sep 7, 2022

Conversation

rickystewart
Copy link
Collaborator

@rickystewart rickystewart commented Aug 12, 2022 •
edited by RaduBerinde
Loading

  • Adjust the Pebble tests to run in new version.
  • Adjust version in Docker image (source).
  • Adjust version in the TeamCity agent image (setup script)
  • Rebuild and push the Docker image (following Basic Process)
  • Run the Internal / Release / Build and Publish Patched Go build configuration in TeamCity with your latest version of the script above. This will print out the new URL's and SHA256 sums for the patched Go that you built above.
  • Update build/teamcity/internal/release/build-and-publish-patched-go/impl.sh with the new version and adjust SHA256 sums as necessary.
  • Bump the version in WORKSPACE under go_download_sdk. You may need to bump rules_go. Also edit the filenames listed in sdks and update all the hashes to match what you built in the step above.
  • Run ./dev generate bazel to refresh distdir_files.bzl, then bazel fetch @distdir//:archives to ensure you've updated all hashes to the correct value.
  • Bump the version in builder.sh accordingly (source).
  • Bump the version in go-version-check.sh (source), unless bumping to a new patch release.
  • Bump the go version in go.mod. You may also need to rerun make vendor_rebuild if vendoring has changed.
  • Bump the default installed version of Go in bootstrap-debian.sh (source).
  • Replace other mentions of the older version of go (grep for golang:<old_version> and go<old_version>).
  • Update the builder.dockerImage parameter in the TeamCity Cockroach and Internal projects.
  • Ask the Developer Infrastructure team to deploy new TeamCity agent images according to packer/README.md

Closes #85908.

Release justification: Upgrade to latest Go version
Release note (build change): upgrade to go 1.19.1

@rickystewart rickystewart added the do-not-merge bors won't merge a PR with this label. label Aug 12, 2022
@rickystewart rickystewart requested a review from a team as a code owner August 12, 2022 17:09
@rickystewart rickystewart requested a review from a team August 12, 2022 17:09
@rickystewart rickystewart requested a review from a team as a code owner August 12, 2022 17:09
@rickystewart rickystewart requested review from srosenberg and removed request for a team August 12, 2022 17:09
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rickystewart rickystewart force-pushed the upgradego119 branch 5 times, most recently from 2eda492 to 16f1412 Compare August 12, 2022 21:20
@rickystewart rickystewart requested a review from a team August 12, 2022 21:20
@rickystewart rickystewart requested review from a team as code owners August 12, 2022 21:20
@rickystewart rickystewart requested a review from a team August 12, 2022 21:20
@rickystewart rickystewart requested review from a team as code owners August 12, 2022 21:20
@rickystewart rickystewart requested a review from a team August 12, 2022 21:20
@rickystewart rickystewart requested review from a team as code owners August 12, 2022 21:20
@rickystewart rickystewart requested review from a team and msbutler and removed request for a team August 12, 2022 21:20
craig bot pushed a commit that referenced this pull request Sep 7, 2022
@knz
Merge #87442
2677a7d 
87442: colexec: remove some empty comment lines r=yuzefovich a=knz

For #86049.

Release justification: non-code changes

Release note: None

Co-authored-by: Raphael 'kena' Poss <knz@thaumogen.net>
@knz knz mentioned this pull request Sep 7, 2022
Closed
@knz
Copy link
Contributor

knz commented Sep 7, 2022

You will probably need #87485 to get over the remaining linter hurdle.

Then for the remaining test failure you need to update the expected test output (I think it's dev test //sql/opt/exec/execbuilder --rewrite)

@rickystewart rickystewart force-pushed the upgradego119 branch 2 times, most recently from 52f65f5 to a19e0af Compare September 7, 2022 15:24
@rickystewart
Copy link
Collaborator Author

You will probably need #87485 to get over the remaining linter hurdle.

I pulled the changes into this commit, except for the uses of ioutil I couldn't get rid of easily, for which I added linter exclusions.

AFAICT this is ready for review now.

@knz
Copy link
Contributor

knz commented Sep 7, 2022

i can spend time on the detailed review but with focused chaos it will likely spread over 2-3 days.

@rickystewart
Copy link
Collaborator Author

i can spend time on the detailed review but with focused chaos it will likely spread over 2-3 days.

I'll check if there's someone on the team who has time to review.

mari-crl
mari-crl approved these changes Sep 7, 2022
View reviewed changes
Copy link
Contributor

@mari-crl mari-crl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sanity check completed!
A lot of ASCII art in our codebase... Some of it seems like it may have gotten misaligned, but I don't think that's a fix to be made here. Get it in there!

:lgtm:

Reviewed 766 of 789 files at r11, 24 of 24 files at r13, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @HonoreDB, @msbutler, and @srosenberg)

@knz
Copy link
Contributor

knz commented Sep 7, 2022

Btw 1.19.1 was just released with applicable security patches. IMHO it would be useful to have this done here right away.

@rickystewart
Copy link
Collaborator Author

TFTR

YOLO

bors r=mari-crl p=99

@craig
Copy link
Contributor

craig bot commented Sep 7, 2022

👎 Rejected by label

@rickystewart rickystewart removed the do-not-merge bors won't merge a PR with this label. label Sep 7, 2022
knz
knz approved these changes Sep 7, 2022
View reviewed changes
Copy link
Contributor

@knz knz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok doing a post-hoc review on this.

Reviewed 7 of 789 files at r11.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @HonoreDB, @msbutler, and @srosenberg)

@rickystewart rickystewart force-pushed the upgradego119 branch 3 times, most recently from 8c6e3ee to 0c786ee Compare September 7, 2022 18:00
@knz knz changed the title *: upgrade to go 1.19 *: upgrade to go 1.19.1 Sep 7, 2022
@rickystewart
*: upgrade to go 1.19.1
2675c7c 
* [ ] Adjust the Pebble tests to run in new version.
* [x] Adjust version in Docker image ([source](./builder/Dockerfile)).
* [x] Adjust version in the TeamCity agent image ([setup script](./packer/teamcity-agent.sh))
* [x] Rebuild and push the Docker image (following [Basic Process](#basic-process))
* [x] Update `build/teamcity/internal/release/build-and-publish-patched-go/impl.sh` with the new version and adjust SHA256 sums as necessary.
* [x] Run the `Internal / Release / Build and Publish Patched Go` build configuration in TeamCity with your latest version of the script above. This will print out the new URL's and SHA256 sums for the patched Go that you built above.
* [x] Bump the version in `WORKSPACE` under `go_download_sdk`. You may need to bump [rules_go](https://github.com/bazelbuild/rules_go/releases). Also edit the filenames listed in `sdks` and update all the hashes to match what you built in the step above.
* [x] Run `./dev generate bazel` to refresh `distdir_files.bzl`, then `bazel fetch @distdir//:archives` to ensure you've updated all hashes to the correct value.
* [x] Bump the version in `builder.sh` accordingly ([source](./builder.sh#L6)).
* [x] Bump the version in `go-version-check.sh` ([source](./go-version-check.sh)), unless bumping to a new patch release.
* [ ] Bump the go version in `go.mod`. You may also need to rerun `make vendor_rebuild` if vendoring has changed.
* [x] Bump the default installed version of Go in `bootstrap-debian.sh` ([source](./bootstrap/bootstrap-debian.sh)).
* [x] Replace other mentions of the older version of go (grep for `golang:<old_version>` and `go<old_version>`).
* [ ] Update the `builder.dockerImage` parameter in the TeamCity [`Cockroach`](https://teamcity.cockroachdb.com/admin/editProject.html?projectId=Cockroach&tab=projectParams) and [`Internal`](https://teamcity.cockroachdb.com/admin/editProject.html?projectId=Internal&tab=projectParams) projects.
* [ ] Ask the Developer Infrastructure team to deploy new TeamCity agent images according to [packer/README.md](./packer/README.md)

Closes cockroachdb#85908.

Release justification: Upgrade to latest Go version
Release note (build change): upgrade to go 1.19.1
@rickystewart
Copy link
Collaborator Author

bors r=mari-crl,knz p=99

@craig
Copy link
Contributor

craig bot commented Sep 7, 2022

Build succeeded:

@craig craig bot merged commit 018e180 into cockroachdb:master Sep 7, 2022
@cockroach-teamcity cockroach-teamcity mentioned this pull request Sep 7, 2022
Closed
@rickystewart rickystewart mentioned this pull request Sep 8, 2022
Closed
@erikgrinaker erikgrinaker mentioned this pull request Sep 16, 2022
Closed
rickystewart added a commit to rickystewart/cockroach that referenced this pull request May 24, 2024
@rickystewart
build: remove swagger
4925362 
We stopped generating the Swagger documentation 2 years ago in cockroachdb#86049
to allow us to upgrade to Go 1.19. A year later, in cockroachdb#105291, we then
deleted the stale tree. To date no one has complained or even noticed
this documentation missing, we've moved on to Go 1.22, and we've had 2
years of releases. Time to just remove support for Swagger altogether,
including the build dependency and the `go:swagger` directives.

I kept the "structured" documentation comments. It may or may not be
out-of-date, but it doesn't seem to be hurting anyone.

Epic: none
Release note: None
@rickystewart rickystewart mentioned this pull request May 24, 2024
Merged
craig bot pushed a commit that referenced this pull request May 24, 2024
@rickystewart
Merge #124674
670640b 
124674: build: remove `swagger` r=rail a=rickystewart

We stopped generating the Swagger documentation 2 years ago in #86049 to allow us to upgrade to Go 1.19. A year later, in #105291, we then deleted the stale tree. To date no one has complained or even noticed this documentation missing, we've moved on to Go 1.22, and we've had 2 years of releases. Time to just remove support for Swagger altogether, including the build dependency and the `go:swagger` directives.

I kept the "structured" documentation comments. It may or may not be out-of-date, but it doesn't seem to be hurting anyone.

Epic: none
Release note: None

Co-authored-by: Ricky Stewart <ricky@cockroachlabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mari-crl mari-crl mari-crl approved these changes

@knz knz knz approved these changes

@srosenberg srosenberg Awaiting requested review from srosenberg srosenberg is a code owner automatically assigned from cockroachdb/test-eng

@msbutler msbutler Awaiting requested review from msbutler

@HonoreDB HonoreDB Awaiting requested review from HonoreDB HonoreDB is a code owner automatically assigned from cockroachdb/cdc-prs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

build: upgrade to go 1.19