*: remove remaining stray uses of ioutil #87485
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
knz
force-pushed
the
20220907-ioutil
branch
2 times, most recently
from
1846e73 to
0fe9026
Compare
Release justification: low risk, high benefit changes to existing functionality Release note: None
|
@rickystewart it looks like the approach I took here (patch github.com/kevinburke/go-bindata into cockroachdb/go-bindata) doesn't work well. Apparently there's a hardcoded dependency to kevinburke/go-bindata in gazelle. So I think in order to silent the ioutil linter for code generated by go-bindata we will need to do something else. I'm not sure what. (Or perhaps we can patch gazelle to use our fork?) |
|
Superseded by #86049. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for #86049.
Release justification: low risk, high benefit changes to existing functionality
Release note: None