backupccl: update progress more frequently #89971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A code comment in the ChunkProgressLogger implementation says: > To avoid hammering the system.jobs table, when a response comes > back, we issue a progress update only if a) it's been a duration of > progressTimeThreshold since the last update, or b) the difference between the > last logged fractionCompleted and the current fractionCompleted is more than > progressFractionThreshold. But as implemented, it would only update the progress if both of those conditions were true. For very large or very slow backups, this meant that progress updates could be _very_ far about, which is a bit disconcerting. Here, I've changed the condition to match the comment, so now, if progress has been made, we should see an update every 15 seconds. Release note (bug fix): Fix bug that could result in infrequent progress updates for very large backup or restore jobs.
|
This change is |
adityamaru
approved these changes
Nov 10, 2022
|
bors r=adityamaru |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A code comment in the ChunkProgressLogger implementation says:
But as implemented, it would only update the progress if both of those conditions were true. For very large or very slow backups, this meant that progress updates could be very far about, which is a bit disconcerting.
Here, I've changed the condition to match the comment, so now, if progress has been made, we should see an update every 15 seconds.
Epic: None
Release note (bug fix): Fix bug that could result in infrequent progress updates for very large backup or restore jobs.