Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backupccl: update progress more frequently #89971

Merged
merged 1 commit into from
Nov 10, 2022

Commits on Oct 14, 2022

  1. backupccl: update progress more frequently

    A code comment in the ChunkProgressLogger implementation says:
    
    > To avoid hammering the system.jobs table, when a response comes
    > back, we issue a progress update only if a) it's been a duration of
    > progressTimeThreshold since the last update, or b) the difference between the
    > last logged fractionCompleted and the current fractionCompleted is more than
    > progressFractionThreshold.
    
    But as implemented, it would only update the progress if both of those
    conditions were true. For very large or very slow backups, this meant
    that progress updates could be _very_ far about, which is a bit
    disconcerting.
    
    Here, I've changed the condition to match the comment, so now, if
    progress has been made, we should see an update every 15 seconds.
    
    Release note (bug fix): Fix bug that could result in infrequent
    progress updates for very large backup or restore jobs.
    stevendanna committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    6866d54 View commit details
    Browse the repository at this point in the history