sql: fix logic test multiline and tabbed output #91702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
fixes #83586 This fixes 2 issues with logic test output: 1) Tabs no longer interfere with tabwriter column output. 2) Newlines no longer interfere with tabwriter row output. Release note: None
rafiss
approved these changes
Nov 10, 2022
There was a problem hiding this comment.
this looks way better! though i don't think we need to backport this, since it's test-only
Reviewed 4 of 56 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained
|
bors r=rafiss |
Spoke offline - will backport to avoid merge conflicts since this touches so many tests. |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #83586
This fixes 2 issues with logic test output:
Release note: None