-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
logictest -rewrite
flag incorrectly formats SHOW CREATE TABLE
indentation
#83586
Labels
C-bug
Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
T-sql-foundations
SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Comments
ecwall
added
C-bug
Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
T-sql-foundations
SQL Foundations Team (formerly SQL Schema + SQL Sessions)
labels
Jun 29, 2022
craig bot
pushed a commit
that referenced
this issue
Nov 10, 2022
89971: backupccl: update progress more frequently r=adityamaru a=stevendanna A code comment in the ChunkProgressLogger implementation says: > To avoid hammering the system.jobs table, when a response comes > back, we issue a progress update only if a) it's been a duration of > progressTimeThreshold since the last update, or b) the difference between the > last logged fractionCompleted and the current fractionCompleted is more than > progressFractionThreshold. But as implemented, it would only update the progress if both of those conditions were true. For very large or very slow backups, this meant that progress updates could be _very_ far about, which is a bit disconcerting. Here, I've changed the condition to match the comment, so now, if progress has been made, we should see an update every 15 seconds. Epic: None Release note (bug fix): Fix bug that could result in infrequent progress updates for very large backup or restore jobs. 91702: sql: fix logic test multiline and tabbed output r=rafiss a=ecwall fixes #83586 This fixes 2 issues with logic test output: 1) Tabs no longer interfere with tabwriter column output. 2) Newlines no longer interfere with tabwriter row output. Release note: None 91706: settingswatcher: address todo for GetStorageClusterVersion r=ajstorm,renatolabs a=rafiss v22 is now minted, so we can use it in this function. On the release-22.2 branch, it's only minted in v22.2.0-rc.1, so we can no longer use v22.2.0-beta.5 for the mixed version tests. Epic: None Release note: None 91712: sql: skip flakey TestSQLStatsIdleLatencies r=ericharmeling a=ericharmeling This commit skips TestSQLStatsIdleLatencies. Part of #91710. Release note: None Co-authored-by: Steven Danna <danna@cockroachlabs.com> Co-authored-by: Evan Wall <wall@cockroachlabs.com> Co-authored-by: Rafi Shamim <rafi@cockroachlabs.com> Co-authored-by: Eric Harmeling <eric.harmeling@cockroachlabs.com>
blathers-crl bot
pushed a commit
that referenced
this issue
Nov 10, 2022
fixes #83586 This fixes 2 issues with logic test output: 1) Tabs no longer interfere with tabwriter column output. 2) Newlines no longer interfere with tabwriter row output. Release note: None
This was referenced Nov 11, 2022
rafiss
added a commit
that referenced
this issue
Nov 14, 2022
rafiss
added a commit
that referenced
this issue
Nov 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
C-bug
Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
T-sql-foundations
SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Running logic tests with the
-rewrite
flag causes the indentation forSHOW CREATE TABLE
to have too much indentation. It looks like the column definitions are always spaced to the right of theWITH (...)
.Results as of 1bf3243448c15a94546ea609380fa02a050edf11 on master:
The formatting is correct in the CLI:
Jira issue: CRDB-17156
The text was updated successfully, but these errors were encountered: