rfcs: update the partial stats collection rfc to reflect implementation #91759
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This change is |
faizaanmadhani
force-pushed
the
faizaan/update-partial-stats-rfc-pred-column
branch
2 times, most recently
from
b855d58 to
7ac2a98
Compare
Previously, the partial statistics rfc indicated that we would need to add a column to `system.table_statistics` that would store a boolean indicating that the statistic is partial. However, the implementation differs from this (cockroachdb#91248) and instead adds a column to store a string containing a predicate. This PR updates the RFC to be consistent with this change. Release note: None Epic: CRDB-19449
faizaanmadhani
force-pushed
the
faizaan/update-partial-stats-rfc-pred-column
branch
from
7ac2a98 to
d2095ec
Compare
faizaanmadhani
changed the title
rytaft
approved these changes
Nov 15, 2022
Collaborator
rytaft
left a comment
rytaft
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @michae2)
Contributor
Author
|
TFTR! 🎉 bors r=rytaft |
Contributor
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the partial statistics rfc indicated
that we would need to add a column to
system.table_statisticsthat would store a boolean indicating that the statistic is partial.
However, the implementation differs from this (#91248)
and instead adds a column to store a string containing a predicate.
This PR updates the RFC to be consistent with this change.
Release note: None
Epic: CRDB-19449