Update schema_locked docs to clarify behavior and improve messaging #21601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cockroachdb-api-docs canceled.
|
Contributor
Author
|
@rmloveland I tagged you here since it builds upon PR #20013, which you added. The release sequencing ended up being confusing. We initially targeted this in 25.3/25.4, then backed it out, but the release notes page did not reflect that. |
✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.
|
✅ Netlify PreviewBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
rafiss
force-pushed
the
schema-locked-fixes
branch
2 times, most recently
from
462a4c6 to
7dbe1dc
Compare
rmloveland
approved these changes
Dec 12, 2025
Contributor
rmloveland
left a comment
rmloveland
left a comment
There was a problem hiding this comment.
LGTM thank you @rafiss !
- session-vars.md (v25.3, v25.4, v26.1): Change description from "disallows schema changes" to "improves changefeed performance". - session-vars.md (v26.1): Update default value to `on`. - table-storage-parameters.md (v25.3, v25.4, v26.1): Change description from "Disallow schema changes" to "Indicates that a schema change is not currently ongoing" and note that CockroachDB automatically handles unsetting/reapplying. - cdc-schema-locked-example.md (v25.3, v25.4, v26.1): Update wording to match, and explain that CockroachDB attempts to automatically unset the parameter but some schema changes (like ALTER TABLE SET LOCALITY) require manual unlock. There was also a sentence that was never completed, which has been removed now. - Release notes: Remove incorrect notes about enabling by default from v25.3 and v25.4, add the release note to v26.1 where it actually applies.
rafiss
force-pushed
the
schema-locked-fixes
branch
from
7dbe1dc to
ae72046
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
on.follow up to PR #20013
relates to DOC-15240