Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_processRentCollection does not check the return value of payRent #133

Closed
code423n4 opened this issue Jun 16, 2021 · 2 comments
Closed

_processRentCollection does not check the return value of payRent #133

code423n4 opened this issue Jun 16, 2021 · 2 comments
Labels
0 (Non-critical) bug Something isn't working duplicate This issue or pull request already exists

Comments

@code423n4
Copy link
Contributor

Handle

pauliax

Vulnerability details

Impact

function payRent declares to return bool. Here it does not assert that:
function _processRentCollection(
...
) internal {
...
treasury.payRent(_rentOwed);

Recommended Mitigation Steps

assert(treasury.payRent(_rentOwed));
@code423n4 code423n4 added 0 (Non-critical) bug Something isn't working labels Jun 16, 2021
code423n4 added a commit that referenced this issue Jun 16, 2021
@code423n4
pauliax issue #133
02a19de
@Splidge Splidge added the duplicate This issue or pull request already exists label Jun 17, 2021
@Splidge
Copy link
Collaborator

Splidge commented Jun 17, 2021

Duplicate of #53

@Splidge Splidge marked this as a duplicate of #53 Jun 17, 2021
@Splidge Splidge closed this as completed Jun 18, 2021
@dmvt
Copy link
Collaborator

dmvt commented Jul 9, 2021

duplicate of #53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 (Non-critical) bug Something isn't working duplicate This issue or pull request already exists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dmvt @Splidge @code423n4