Unused return value from orderbook.findNewOwner() and treasury.payRent()

[code423n4]

Handle

JMukesh

Vulnerability details

Impact

checking the return value from function indicates ether function call was success or failure because of that, we should utilise the return value

Proof of Concept

In RCmarket.sol

https://github.com/code-423n4/2021-06-realitycards/blob/main/contracts/RCMarket.sol#L1025

https://github.com/code-423n4/2021-06-realitycards/blob/main/contracts/RCMarket.sol#L1060

Tools Used

slither

Recommended Mitigation Steps

Utilize return value

[Splidge]

These return values aren't required, instead of using them I'll just remove them.

[Splidge]

fixed here