functions safeTransferFrom and transferFrom are too similar

[code423n4]

Handle

pauliax

Vulnerability details

Impact

function safeTransferFrom is almost identical to function transferFrom. It would be better to reduce code duplication by re-using the code.

Recommended Mitigation Steps

function safeTransferFrom(
address from,
address to,
uint256 tokenId,
bytes memory _data
) public override {
transferFrom(from, to, tokenId);
_data;
}

[Splidge]

implemented here
Although I've since noted another issue which will probably require undoing this as they will become dissimilar again.

[Splidge]

Due to issue #118 we have changed to using the _beforeTokenTransfer hook, which means these overrides were no longer required. They were removed in this commit.