Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SettToRenIbbtcZap.sol#setGuardian doesn't set the guardian, but governance #10

Closed
code423n4 opened this issue Nov 15, 2021 · 2 comments
Closed
Labels
3 (High Risk) bug Something isn't working duplicate This issue or pull request already exists sponsor confirmed

Comments

@code423n4
Copy link
Contributor

Handle

0x0x0x

Vulnerability details

Proof of Concept

This function is intended to change the guardian, but the code changes the governance address as seen in the code:

    function setGuardian(address _guardian) external {
        _onlyGovernance();
        governance = _guardian;
    }

It should be replaced with the following code to have the functionality of setting guardian.

    function setGuardian(address _guardian) external {
        _onlyGovernance();
        guardian = _guardian;
    }

Tools Used

Manual analysis

@code423n4 code423n4 added 1 (Low Risk) bug Something isn't working labels Nov 15, 2021
code423n4 added a commit that referenced this issue Nov 15, 2021
@tabshaikh
Copy link
Collaborator

Fixed

@0xleastwood
Copy link
Collaborator

duplicate of #51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 (High Risk) bug Something isn't working duplicate This issue or pull request already exists sponsor confirmed
Projects
None yet
Development

No branches or pull requests

3 participants