Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing hasStarted modifier, can lead to user vesting before the owner begin the vesting #89

Closed
code423n4 opened this issue Nov 13, 2021 · 2 comments
Closed

Missing hasStarted modifier, can lead to user vesting before the owner begin the vesting #89

code423n4 opened this issue Nov 13, 2021 · 2 comments
Labels
bug Something isn't working invalid This doesn't seem right LinearVesting sponsor disputed Sponsor cannot duplicate the issue, or otherwise disagrees this is an issue

Comments

@code423n4
Copy link
Contributor

Handle

rfa

Vulnerability details

Impact

In the vestFor() function, the user can vest their vader token for a certain amount of time, but hasStarted modifier is missing,
this can lead to vestFor() function is callable by anyone, eventhough the owner havent begin the vesting yet.

Proof of Concept

https://github.com/code-423n4/2021-11-vader/blob/main/contracts/tokens/vesting/LinearVesting.sol#L214

Tools Used

Recommended Mitigation Steps

add hasStarted modifier
@code423n4 code423n4 added 2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working labels Nov 13, 2021
code423n4 added a commit that referenced this issue Nov 13, 2021
@code423n4
rfa issue #89
1b74726
@SamSteinGG SamSteinGG mentioned this issue Nov 25, 2021
Open
@SamSteinGG SamSteinGG added the sponsor disputed Sponsor cannot duplicate the issue, or otherwise disagrees this is an issue label Nov 25, 2021
@SamSteinGG
Copy link
Collaborator

This is intended as the global vesting start bears no effect on the per-user vesting of the converter.

@alcueca
Copy link
Collaborator

alcueca commented Dec 11, 2021

Dispute accepted

@alcueca alcueca added invalid This doesn't seem right and removed 2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value labels Dec 11, 2021
@alcueca alcueca closed this as completed Dec 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working invalid This doesn't seem right LinearVesting sponsor disputed Sponsor cannot duplicate the issue, or otherwise disagrees this is an issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@alcueca @code423n4 @SamSteinGG @0xstormtrooper