Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing hasStarted modifier, can lead to user vesting before the owner begin the vesting #90

Open
code423n4 opened this issue Nov 13, 2021 · 3 comments
Open

Missing hasStarted modifier, can lead to user vesting before the owner begin the vesting #90

code423n4 opened this issue Nov 13, 2021 · 3 comments
Labels
2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working LinearVesting

Comments

@code423n4
Copy link
Contributor

Handle

rfa

Vulnerability details

Impact

In the claimConverted() function, the user can vest their vader token for a certain amount of time, but hasStarted modifier is missing,
this can lead to claimConverted() function is callable by anyone, and the user can claim eventhough the vesting havent been started by the owner.

Proof of Concept

https://github.com/code-423n4/2021-11-vader/blob/main/contracts/tokens/vesting/LinearVesting.sol#L158

Tools Used

Recommended Mitigation Steps

add hasStarted modifier
@code423n4 code423n4 added 2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working labels Nov 13, 2021
code423n4 added a commit that referenced this issue Nov 13, 2021
@code423n4
rfa issue #90
4f6953b
@SamSteinGG SamSteinGG added the duplicate This issue or pull request already exists label Nov 25, 2021
@SamSteinGG
Copy link
Collaborator

Duplicate of #89

@SamSteinGG SamSteinGG marked this as a duplicate of #89 Nov 25, 2021
@alcueca alcueca added invalid This doesn't seem right and removed duplicate This issue or pull request already exists 2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value labels Dec 10, 2021
@alcueca
Copy link
Collaborator

alcueca commented Dec 10, 2021

Not a duplicate, different line.

@alcueca alcueca reopened this Dec 10, 2021
@alcueca alcueca added 2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value and removed invalid This doesn't seem right labels Dec 15, 2021
@SamSteinGG
Copy link
Collaborator

@alcueca This should be invalid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working LinearVesting
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@alcueca @code423n4 @SamSteinGG @0xstormtrooper