Bug: Extension still keeps pausing the player. Not solved.

[IveMalfunctioned]

As I previously stated in #1387, this extension keeps causing the player to pause every time I try to unpause it making the site unusable. This is most likely caused by disabling the "Autoplay" setting.

[ImprovedTube]

hi :) @IveMalfunctioned
did you test the latest version from our repo? (pending review by webstore)

if so, you might want to link the author of the latest fixes here:
https://github.com/code-for-charity/ImprovedTube-for-YouTube/pulls?q=autoplay

[raszpl]

I think 4.0.35 beta release just broke completely, doesnt stop autoplay

[ImprovedTube]

hi @raszpl !
really?
we didnt change much but just fixed the bug/typo, that made playlist auto-play:off would interfere with all videos.
https://github.com/code-for-charity/ImprovedTube-for-YouTube/pull/1585/files#diff-4d1507dc59c10564725a4660d09d45a5af1441f0e671391aed77bfd9d7dc2194

There already was an exception, when you happen to click the player - or press any key,
while the URL bar already shows the new video's ID, then autoplay:off won't happen. (thats unlikely a mistake. Plus the first line of the code above by @MohamedLebda, tries to make sure that this exception only happens once at most)

[raszpl]

I reset all the settings and still autoplaying and not applying some settings. Looked in console and found

Uncaught TypeError: Cannot read properties of null (reading '0')
    at ImprovedTube.themes (themes.js:84:60)
    at ImprovedTube.init (init.js:45:15)
    at HTMLDocument.<anonymous> (core.js:124:17)

doesnt like content-scripts/website-context/youtube-features)/themes.js

const pref = document.cookie.match(/PREF\=.*(f6=[^\&]+)/)[0];

obviously I dont have the cookie it expects without checking first.
Thats 4.0.35 beta, cant see any changes in main repository

[ImprovedTube]

thanks! @raszpl hope you will get your deserved spot in the top few contributors here.
it's the most recent PR @dodieboy 👋, where this line appears in themes.js & shortcuts.js

https://github.com/code-for-charity/ImprovedTube-for-YouTube/pull/1589/files#diff-56c883cd27025fb736c0abe98204491fcf2315d16ae3489f45f71bb56a092a0e

also this line should not happen without intentional dark mode nor themes per users setting.

---

Old news: Anything that can ever fail, or slow down the process, needs to run async setTimeout( ,0);
and/or with an alternative try{ } catch(err){console.log(err);} finally { someAlternative(); }

---

Our cookie code:

• Current (split file structure): https://github.com/search?q=repo%3Acode-for-charity%2FImprovedTube-for-YouTube++cookie+language%3AJavaScript&type=code&l=JavaScript

• Old stable (single file): https://github.com/code-for-charity/ImprovedTube-for-YouTube/blob/28f1bef13c0f77c2b9c5200ec9c7868b8d354629/youtube-scripts.js#L617

[dodieboy]

My bad, will fixed this bug now

[raszpl]

Im sorry, I dont know how I missed that code in the repository yesterday.

that https://github.com/code-for-charity/ImprovedTube-for-YouTube/blob/4b8f02a198ec3aa83c511b7acf866cb052e2c6e3/content-scripts/website-context/youtube-features/settings.js#L275 sure looks cleaner

[ImprovedTube]

thanks @raszpl @IveMalfunctioned