Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme fix #1589

Merged
merged 3 commits into from
Feb 26, 2023
Merged

Theme fix #1589

merged 3 commits into from
Feb 26, 2023

Conversation

dodieboy
Copy link
Member

A quick fix for the theme system.

Sorry for not that active recently, my laptop spoiled and also busy with work.

Now the theme will pick the youtube appearance by itself.
The page will now reload when need to change appearance
@ImprovedTube
Copy link
Member

Glad to hear from you! @dodieboy Are you on Discord?

work

may we help you anything too?🤫😊

BTW / for later this fix was not moved to v4? https://github.com/code-for-charity/ImprovedTube-for-YouTube/pull/1372/files
#1393 also persists (with unlimied page width) ( #1407 )

@ImprovedTube ImprovedTube merged commit 86545ce into code-charity:master Feb 26, 2023
@dodieboy
Copy link
Member Author

dodieboy commented Feb 27, 2023

I will take a look this weekend

ImprovedTube pushed a commit that referenced this pull request Mar 3, 2023
@dodieboy dodieboy deleted the Theme-Fix branch March 4, 2023 01:23
@MohamedLebda
Copy link
Contributor

The code works well. but a little notice that in chrome custom theme won't have an effect unless I manually refresh the page or change the theme to anything else and then change it back but it works fine in Firefox
also, there is a strange behavior in both firefox and chrome that if you pick the farthest northwest color as in the photo it will get nan in firefox and , , in chrome which make the color black instead of white 255, 255, 255
theme-custom

@ImprovedTube ImprovedTube removed the request for review from MohamedLebda March 5, 2023 23:55
@ImprovedTube
Copy link
Member

ImprovedTube commented Mar 5, 2023

fartest north west.

we can fix that in the our Repo: "Satus"

  • Most importantly: playerSize() seems not defined anymore when the extension runs as of a previous PR?

ImprovedTube added a commit that referenced this pull request Mar 10, 2023
ImprovedTube pushed a commit that referenced this pull request Jan 12, 2024
ImprovedTube added a commit that referenced this pull request Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants