Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed hide detail button not working #1411

Merged
merged 6 commits into from
Oct 1, 2022

Conversation

dodieboy
Copy link
Member

Now hideDetailButton() use the svg path to read the button. This is to support all language.

Now hideDetailButton() use the svg path to read the button. This is to support all language.
@ImprovedTube
Copy link
Member

ImprovedTube commented Sep 27, 2022

🤩
need nth-child(3) ?

What about matching the SVGs by the first characters? (code size doesn't matter. Only speed) (+imaginable to predict slight changes if it is for free)

@dodieboy
Copy link
Member Author

The ntd-child(3) is also to improve performance since all video will have share button unlike other buttons.

It is a good idea to use the first few numbers for svg, i will update and test it this weekend.(currently do not have my device)

@ImprovedTube
Copy link
Member

ImprovedTube commented Sep 28, 2022

Hi! Also hides the clip button and morre random youtube buttons beyond that.
So need to check svg there too. (it doesn't say the 3rd button. besides that orders can change. Mobile: )

css ( #menu #button path[d^="M15,5.63L20.66,12L15,18"] {visibility:hidden;} works too,
so the feature only needs JS, incase of hiding the parent link too
a > yt-icon-button > button > yt-icon > svg > g > path)

@ImprovedTube
Copy link
Member

ImprovedTube commented Sep 29, 2022

we can offer all detail buttons: remove labels to improve this menu (to fit on all screens.)
(as a feature - or potentially even by default? since nobody needs the labels. Especially on small screens)

#menu ytd-button-renderer div:nth-child(2) {display:none;}

youtube buttons no labels

previously: #menu ytd-button-renderer #text {display:none;}

  • alternatives / future-fixes
   #menu ytd-button-renderer .cbox {display:none;}
   #menu ytd-button-renderer div[class*='text'] {display:none;}
   #menu ytd-button-renderer div[class$='content'] {display:none;}

UX Debate

  • Parent-features before Child-Features Sorting/marking up features by "functionality > saving time > taste" #1429
  • winning back the space losing no buttons on old screens
    • thus we can also make a feature to always show the transcript button (or buttons by improvedtube)
  • thumbs position shouldnt change (accidental clicks are possible) how ever it will be closer to how it always used to be in
    youtube's best years until relatively recently

Options:

  • faint/transparent #menu button {opacity:0.5;}

  • remove #menu button {display:none;}

  • remove icons #menu button div:first-child {display:none;}

  • invisible labels #menu ytd-button-renderer div:nth-child(2) {visibility:hidden}

    • (advantage: positions dont change, in case people are used to it)

@dodieboy
Copy link
Member Author

dodieboy commented Oct 1, 2022

Hey @ImprovedTube, I have shorten the svg, share button now use svg and added hide detail button label feature too

@dodieboy
Copy link
Member Author

dodieboy commented Oct 1, 2022

The hide label feature, the user can select which label they do not want to see

@dodieboy
Copy link
Member Author

dodieboy commented Oct 1, 2022

Fix #1400 and added #980 css code to fix description expand not working

@ImprovedTube
Copy link
Member

ImprovedTube commented Oct 1, 2022

😮 aweesomee, phenomenal!

@ImprovedTube ImprovedTube merged commit f22a1f7 into code-charity:master Oct 1, 2022
@ImprovedTube
Copy link
Member

ImprovedTube commented Oct 1, 2022

back here (to be precise / summary)

#menu #button path[d^="M15,5.63L20.66,12L15,18"] {visibility:hidden;} works too,
so it just needs JS for hiding the parent link.

*=so this will (should) win benchmarks. ( & #menu ID looks permanent )


--

...

#menu ytd-button-renderer #text {display:none;}
Screenshot_30

*=Such single feature could be in our features for those who dont look for more detail (maybe at least 50000 people).
And only be replaced for those who will set button by button (maybe at least 50000 people too - even if of course the second/detailed half is always rarer/much more work/ deserving more honor.)

closer to how it always used to be in "youtube's best years" until "relatively recently"

*=feature could be part of a general lite-theme/compact-mode #868.

@dodieboy dodieboy deleted the Fix-hide-detail-button branch October 2, 2022 03:05
ImprovedTube added a commit that referenced this pull request Oct 16, 2022
Fixed hide detail button not working
ImprovedTube added a commit that referenced this pull request Oct 18, 2022
Fixed hide detail button not working
ImprovedTube added a commit that referenced this pull request Oct 18, 2022
Fixed hide detail button not working
@ImprovedTube ImprovedTube mentioned this pull request Mar 4, 2023
ImprovedTube added a commit that referenced this pull request Apr 4, 2023
ImprovedTube added a commit that referenced this pull request Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants