-
-
Notifications
You must be signed in to change notification settings - Fork 552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed hide detail button not working #1411
Fixed hide detail button not working #1411
Conversation
Now hideDetailButton() use the svg path to read the button. This is to support all language.
🤩 What about matching the SVGs by the first characters? (code size doesn't matter. Only speed) (+imaginable to predict slight changes if it is for free) |
The ntd-child(3) is also to improve performance since all video will have share button unlike other buttons. It is a good idea to use the first few numbers for svg, i will update and test it this weekend.(currently do not have my device) |
we can offer #menu ytd-button-renderer div:nth-child(2) {display:none;}previously:
UX Debate
Options:
|
Hey @ImprovedTube, I have shorten the svg, share button now use svg and added hide detail button label feature too |
The hide label feature, the user can select which label they do not want to see |
😮 aweesomee, phenomenal! |
back here (to be precise / summary)
*=so this will (should) win benchmarks. ( & #menu ID looks permanent ) -- ... *=Such single feature could be in our features for those who dont look for more detail (maybe at least 50000 people).
*=feature could be part of a general lite-theme/compact-mode #868. |
Fixed hide detail button not working
Fixed hide detail button not working
Fixed hide detail button not working
Now hideDetailButton() use the svg path to read the button. This is to support all language.