Quick fix

[dodieboy]

No description provided.

[dodieboy]

Glad to hear from you! @dodieboy Are you on Discord?

work

may we help you anything too?🤫😊

BTW / for later this fix was not moved to v4? https://github.com/code-for-charity/ImprovedTube-for-YouTube/pull/1372/files #1393 also persists (with unlimied page width) ( #1407 )

@ImprovedTube I added more check for my cookie code to prevent error and also port over my player element overlap code to v4 alr

[ImprovedTube]

thanks & happy weekend @dodieboy

(

• so you decided against location.reload(); for darkmode?
• people werent able to undo darkmode before unless deleting cookies. So, without looking at it, i wondered to remove the option and leave it to YouTube's menu

)

[dodieboy]

location.reload(); may cause a reload loop, so if need, we will suggest user to reload by themself better than the extension keep reloading that cause memory problem to user.

I tested that youtube now set and delete the cookie when user set the appearance in the setting, so user will mot need to know how to delete those cookie when the not using our extension, they can just go appearance and reset those setting.

[dodieboy]

btw i got 1 more fix, so dont merge this PR yet

[dodieboy]

@ImprovedTube I'm done with fixing thing, can merge this PR after review. Thanks 😄

[ImprovedTube]

• detail buttons: also continues thinking of the 'parent-feature' Fixed hide detail button not working #1411 (comment) (updated) + always showing transcript button (if not always showing whole transcript)

• nostalgic to see your SVG matching go ( https://github.com/code-for-charity/ImprovedTube-for-YouTube/blob/92af3dfe94f2374a06bf240e87a09b659f0946c0/content-scripts/website-context/youtube-features/appearance.js#L301 )

• node.classList.contains('ytd-expander') is for performance? making sure for now:
  node.classList.contains('ytd-expander') || node.parentNode.parentNode.id === 'container'

[dodieboy]

On my side, I got an error which show it is not able to find the parent parent node,therefore, i change the check to use the new class name which youtube just added.

I change the SVG method too due to the new change. The button is taking too long to load, resulting in queryselector not able to find the element needed. So I change to this method for now. However I wish that I can bring back the SVG method as we will have lesser work when they added more button there and the extension will hide the correct button even when youtube have a new update

[ImprovedTube]

• darkmode: sorry this brings back a familiar issue, that only the header is black (@dodieboy)
  (=setting darktheme in youtube & no settings in Improvedtube)

  • also: light theme in youtube wont take effect if setting dark in the extension).
    • maybe we could set both the same way the youtube does, so that it would change in Youtube's menu too)

• detail buttons: (only) the first 2-3 are matched by CSS yet

hope you get enough rest too😳