Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V4.0.1 BUGS *edited Nov19* #1495

Open
2 of 7 tasks
ImprovedTube opened this issue Nov 15, 2022 · 19 comments
Open
2 of 7 tasks

V4.0.1 BUGS *edited Nov19* #1495

ImprovedTube opened this issue Nov 15, 2022 · 19 comments
Assignees
Labels
bounty Will pass on donations (Optional) - (OR: Requester will pay personally. Only if stated!) Bug Bug or required update after YouTube changes help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥

Comments

@ImprovedTube
Copy link
Member

ImprovedTube commented Nov 15, 2022

None of these 3 remaining bugs below seem to happen with the old stable version? 3.965 (old satus) nor 3.946

(Colin Stuart41:) "Few new issues just popped up.

  • "3) Videos play for a half second and then pause themselves"
  • "2) When you look at the Videos on a channel, it doesn't load them all (only loads a single row of a few of them). "
    • couldn't reproduce yet
    • might be solved, if it is the same as "a)" in #1493 same for this:
      • 6) "In serch page sumbnails were shown in 4 colums before but now only 2 colums shown. Your extension is very useful and only choice to resize to fit ultrawide display nicely. I'm glad if you fix this bug. Thank you." (by Daisky)
        • just 1 col, no? - cant reproduce both
  • 5) "I'm using ultrawide display"..."player layout isn't shown correctly. Channel info under the player overwraps the player and can't adjust volume displaysize( miniplayer, theater mode)."

  • 4) "Hide Detail Button".."doesn't work. " (Nice Good)
    (partly solved thanks to Quick fix #1597)
  • "1) 😱Two description boxes on YT vids." ( same as #1493 "1." ) - (Sorry it sounded easier in #1400 @dodieboy*
    • = "Hidden" was broken & the feature couldnt be be turned off (Our normal is now "classic normal")
@ImprovedTube ImprovedTube added Bug Bug or required update after YouTube changes help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) important Critical or common. Thus to prioritize labels Nov 15, 2022
@ImprovedTube
Copy link
Member Author

ImprovedTube commented Nov 16, 2022

Confirming, which of these bugs happens only in 4.0.1 (Users might know much already.)

bug 4.0.1 4.0(Victor) BETA 3.1001 3.965 3.946
1 🐞 ✔️ ✔️ 🐞 ✔️
b ? ? ? ? ?
3 autoplay 🐞 🐞(if not #1436) ✔️ ? ✔️ ? ✔️
2 ? ? ✔️? ✔️
6 ? ✔️
5 ? ✔️
#1485 done ? 🐞 🐞

Need to review the lines of code missing from there.
Almost none was useless.

( from #1439 )

More precisely:

  1. v4: New Satus.js , succeeded by 4.0.1 to include recent 40 PRs. Thanks to @dodieboy

  2. 3.965 (repo Oct9) still got the old stable Satus.js without new bugs. And all code in one file. We should compare all missing code to make sure we dont miss anything.

  3. 3.946 stable (Aug18) Inbetween. ( 4. in between: BETA 3.1001 (Jul18) undocumented. Already came with Mf3 ( only options.html is split already rest isnt.) )


this update is seriously good. I love it

did you notice an improvement only in v4+?


done:

bug 4.0.1 4.0(Victor) BETA 3.1001 3.965 3.946
a (#1493) 🐞 ✔️ ✔️ ? ✔️ ?
c done 🐞 ✔️ ✔️ ? ✔️
d couldnt reproduce ?
e done ✔️ ✔️ ? ✔️ ?
g done 🐞 🐞 🐞 🐞
4 hiding detail buttons 🐞 (youtube DOM changed twice) 🐞 🐞 🐞 🐞

@ImprovedTube
Copy link
Member Author

ImprovedTube commented Nov 16, 2022

Issue managment and such a table can be done & collaborated easiest on Github.com through first adding the issues to a "Project"

https://github.com/orgs/code-for-charity/projects/7/views/1

@Anoaxx
Copy link

Anoaxx commented Nov 16, 2022

What bravo do to you? D:

@Anoaxx
Copy link

Anoaxx commented Nov 17, 2022

About being directed to wrong channel. Im not a programmer but maybe its a good thing to look at "Handles" that can change channel link adress

@ImprovedTube
Copy link
Member Author

B) Sometimes player cant load extension options. And even if i dont allow 60fps its still apears. I don't know what causes it. It was happening on older versions too, but less frequently and less annoying. Main differance is that now i must open new tab(and sometimes still dont repairs) but then refresh repairs this problem. Even if it can't be repaired entirely just try to change this behaviour to repair itself after refresh & optionally add some sort of tip or warning that says "if something dont work try refresh the page

This important - Do you remember more? @Anoaxx What other version/s?

@Anoaxx
Copy link

Anoaxx commented Nov 18, 2022

it started i think after you release version 3.0, but refreshing page always repairs the problem. i didn't open any issues on this because it wasn't that bad. But after 4.0 sometimes this still remains. i dont know maybe just chrome didn't load everything yet after opening it and extensio just dont load some stuff?

@dodieboy
Copy link
Member

dodieboy commented Nov 18, 2022

About being directed to wrong channel. Im not a programmer but maybe its a good thing to look at "Handles" that can change channel link adress

@Anoaxx can I know what you click which directed you to wrong channel? is it from video page, detail section or the comment section? or the sidebar?

@jovibor
Copy link

jovibor commented Nov 18, 2022

  • Videos play for a half second and then pause themselves"

Can confirm, happens regularly.

Also, for about 3 days already, some YouTube videos, when opened in a new window, might not get paused at all, video just plays. After page reload (F5) play stops. These videos are random.
It never happened before (even once), for about a year of using this extension.

@Anoaxx
Copy link

Anoaxx commented Nov 19, 2022

@Anoaxx can I know what you click which directed you to wrong channel? is it from video page, detail section or the comment section? or the sidebar?

I just assume that maybe Handles are the problem here, but i never encounter this issue and i didn't write it.

@dodieboy
Copy link
Member

@Anoaxx can I know what you click which directed you to wrong channel? is it from video page, detail section or the comment section? or the sidebar?

I just assume that maybe Handles are the problem here, but i never encounter this issue and i didn't write it.

Ah i see, I also never encounter this problem, that why I'm asking.

@Anoaxx
Copy link

Anoaxx commented Nov 19, 2022

Also, for about 3 days already, some YouTube videos, when opened in a new window, might not get paused at all, video just plays. After page reload (F5) play stops. These videos are random. It never happened before (even once), for about a year of using this extension.

Same with not loading some options like "allow 60 fps = off" etc. I never notice it was in new tab, but maybe thats a problem.

Ah i see, I also never encounter this problem, that why I'm asking.

im thinking its seriously rare bug and its not even extension problem. But that just me.

@ImprovedTube ImprovedTube changed the title V4.0.1 BUGS V4.0.1 BUGS *edited Nov19* Nov 19, 2022
@ImprovedTube
Copy link
Member Author

ImprovedTube commented Nov 19, 2022

I never notice it was in new tab, but maybe thats a problem.

If so, that makes sense @Anoaxx please check.

im thinking its seriously rare bug and its not even extension problem. But that just me.

it's important even if mysterious. Doesnt sound too rare.


  • Videos play for a half second and then pause themselves"

Can confirm, happens regularly.

Also, for about 3 days already, some YouTube videos, when opened in a new window, might not get paused at all, video just plays. After page reload (F5) play stops. These videos are random. It never happened before (even once), for about a year of using this extension.

  • so we can find solution in the last stable? ( 3.946 ) & should get it back for today? @jovibor @Anoaxx Let's confirm whats the difference for these bugs in 3.1001 (="beta" till nov14) and 3.965 (or maybe firefox/edge) & v4.0
bug 4.0.1 4.0(Victor) BETA 3.1001 3.965 3.946
3 autoplay 🐞 🐞(if not #1436) ✔️ ? ✔️ ? ✔️

@Anoaxx
Copy link

Anoaxx commented Nov 19, 2022

is long as i remember this occures the same from .946 to 4.0.1

@ImprovedTube
Copy link
Member Author

you just said less frequently & i didnt know if you used main or beta before.
While Jovibor's just started now.

@Anoaxx
Copy link

Anoaxx commented Nov 21, 2022

from 3.0 i was using beta. And since then this occures in the same way and yes less frequetly, but still in the same way.

@suparnaghosh934
Copy link

suparnaghosh934 commented Nov 21, 2022 via email

@ImprovedTube ImprovedTube removed the important Critical or common. Thus to prioritize label Mar 13, 2023
@ImprovedTube ImprovedTube added the up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥ label Apr 29, 2023
@ImprovedTube ImprovedTube removed their assignment May 10, 2023
@HanzCEO
Copy link
Contributor

HanzCEO commented Jun 25, 2023

Are all these issues resolved?

@ImprovedTube ImprovedTube added the bounty Will pass on donations (Optional) - (OR: Requester will pay personally. Only if stated!) label Nov 5, 2023
@Anoaxx
Copy link

Anoaxx commented Nov 8, 2023

as i can see "autoplay=off" still plays a half a second of a video if u are opening video in new tab and go to it right after opening, and if u are opening video in "queue" its still playing even if autoplay is off

@ImprovedTube
Copy link
Member Author

(Assignments are not exclusive. And mostly just wishful.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bounty Will pass on donations (Optional) - (OR: Requester will pay personally. Only if stated!) Bug Bug or required update after YouTube changes help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥
Projects
Status: Todo
Development

No branches or pull requests

7 participants