Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expanded descriptions not working #1400

Closed
ebyrne242 opened this issue Aug 27, 2022 · 15 comments
Closed

Expanded descriptions not working #1400

ebyrne242 opened this issue Aug 27, 2022 · 15 comments
Labels
Bug Bug or required update after YouTube changes help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) 🧩Plan ready Solution or some specification noted; To-Do; steps for implementation (+raw brainstorming too maybe) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥

Comments

@ebyrne242
Copy link

ebyrne242 commented Aug 27, 2022

Bug Report:

BUG: Setting description to expanded doesn't expand the description.

HOW: Set Appearance -> Details -> Description to Expanded. Visit any video, descriptions are never expanded.

EXPECTED (/preferred) behavior: description is auto-expanded so you don't have to click "more".

Screenshots:
image

Setup:

⚬ ImprovedTube Version: 3.946
⚬ Browser: Chrome 104.0.5112.101 (Official Build) (64-bit)
⚬ Settings:
{"description":"expanded","ga":1661576220192,"header_improve_logo":false,"how_long_ago_the_video_was_uploaded":false,"theme":"dark"}
⚬ OS: Linux, Fedora 36

@ebyrne242 ebyrne242 added Bug Bug or required update after YouTube changes help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) labels Aug 27, 2022
@dodieboy
Copy link
Member

dodieboy commented Sep 9, 2022

Based on the setting you given, I did not see that you enable Expanded for Description.
It should have "description":"expanded"

@ImprovedTube
Copy link
Member

@sketch242 welcome! :) doesnt work indeed. just wonder why nobody else reported this

@ImprovedTube ImprovedTube added this to the Easy / little milestone Sep 29, 2022
@ImprovedTube
Copy link
Member

ImprovedTube commented Sep 29, 2022


@ImprovedTube ImprovedTube added 🧩Plan ready Solution or some specification noted; To-Do; steps for implementation (+raw brainstorming too maybe) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥ labels Sep 29, 2022
@ImprovedTube ImprovedTube moved this to Done in Priority A Oct 1, 2022
ImprovedTube pushed a commit that referenced this issue Oct 16, 2022
ImprovedTube pushed a commit that referenced this issue Oct 18, 2022
ImprovedTube pushed a commit that referenced this issue Oct 18, 2022
@ImprovedTube ImprovedTube moved this from Done to Todo in Priority A Oct 20, 2022
@ImprovedTube ImprovedTube reopened this Jan 20, 2023
MohamedLebda added a commit to MohamedLebda/ImprovedTube-for-YouTube that referenced this issue Feb 25, 2023
MohamedLebda added a commit to MohamedLebda/ImprovedTube-for-YouTube that referenced this issue Feb 25, 2023
MohamedLebda added a commit to MohamedLebda/ImprovedTube-for-YouTube that referenced this issue Feb 25, 2023
MohamedLebda added a commit to MohamedLebda/ImprovedTube-for-YouTube that referenced this issue Feb 25, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in Priority A Mar 17, 2023
@ImprovedTube
Copy link
Member

thanks @ebyrne242

@xeophyte
Copy link

xeophyte commented Dec 6, 2023

Same here Description>Expanded very often not working.
ImprovedTube Version: 4.443
It's not working on every new tab (on current or new tab).

image

It works however after refreshing current tab, but when I go directly to some other video, the description doesn't show again.
Page source:
https://gist.github.com/xeophyte/9b03111457cd6967b1598eb2f183baa5
ImprovedTube settings:
improvedtube.json

@xeophyte xeophyte reopened this Dec 6, 2023
@ImprovedTube
Copy link
Member

hi @xeophyte made the feature click the description a second time after 7 seconds!

@xeophyte
Copy link

xeophyte commented Dec 7, 2023

I do not know what it means ;]

@ImprovedTube
Copy link
Member

hi @xeophyte, it always "clicks" the description (=expand) 0.3s after observing changes with the description.
For now i made all these clicks repeat after 7s. Please try if this timing helps to cover all your tabs. This is for testing (not impossible that somebody clicks "show less" as fast as possible and then wonders what happens)

else we could also just repeat running a list of our feature on focus (=when a tab becomes active) (- if there is no easy explanation and more elegant way)

@xeophyte
Copy link

xeophyte commented Dec 7, 2023

I'm not sure if I understood, but for me expanding the description after 7 seconds is definitely too late. It should expand immediately after loading each page or immediately after activating (navigating to) a given tab.

@ImprovedTube
Copy link
Member

hi @xeophyte, you can still try if it is a remedy at all for the bug you got or no.
( + seems unlikely that you will want a tab in the background only for a few seconds)

@ImprovedTube
Copy link
Member

hi! @xeophyte did you try with the new version?

@xeophyte
Copy link

xeophyte commented Jan 6, 2024

hi! @xeophyte did you try with the new version?

On 4.583 I think it's still the same.
YT videos opened in the same tab (like from related or next from playlist) opens without description expanded.
It only expands when I refresh the current page or open some YT tab in the background (new YT tab already got expanded description).

ImprovedTube pushed a commit that referenced this issue Jan 12, 2024
ImprovedTube pushed a commit that referenced this issue Jan 12, 2024
@ImprovedTube
Copy link
Member

hi @xeophyte please try v4.644+

@xeophyte
Copy link

hi @xeophyte please try v4.644+

There is no such version https://github.com/code-charity/youtube/releases

ImprovedTube added a commit that referenced this issue Feb 22, 2024
@xeophyte
Copy link

xeophyte commented Mar 4, 2024

Looks like fixed for me in 4.704.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Bug or required update after YouTube changes help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) 🧩Plan ready Solution or some specification noted; To-Do; steps for implementation (+raw brainstorming too maybe) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥
Projects
Status: Done
Development

No branches or pull requests

4 participants