Fix #1604
Merged
Fix #1604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We will let youtube to pick the theme for default theme now
Prevent "Uncaught TypeError: Cannot read properties of undefined (reading 'id')"
|
Thanks😮🤩 |
ImprovedTube
added a commit
that referenced
this pull request
Mar 16, 2023
ImprovedTube
added a commit
that referenced
this pull request
Jan 12, 2024
ImprovedTube
added a commit
that referenced
this pull request
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cookie method is not very stable and I miss understand the theme default meaning, theme default should be use youtube default setting (the youtube Appearance option) to theme. Therefore, now it will reload the page if default is select after user selected a dark or black theme. Pls try it out before merging the master, thks.
I also added a check for ImprovedTube.description() to prevent error msg popup.