Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: put player buttons under one button #1842

Merged

Conversation

pg2511
Copy link
Member

@pg2511 pg2511 commented Nov 18, 2023

Resolving Issue: #1837
Hello, @ImprovedTube , this PR is created to resolve the issue of putting up the player buttons under one button.

Here is a detailed video as a result of changes done:
bindingbutton.webm

How it works:

  • Go to Player
  • There is a button Hamburger Menu below the fit to window button, turn it on
  • Now all the right controls will be packed in one
  • When you click on Hamburger Menu the options will be show, and opacity of Hamburger Icon will reduce indicating it is clicked
  • When pressed again the options will collapse in a bar.

Have a look, and please merge this PR, feel free to share suggestions if any.

@ImprovedTube ImprovedTube merged commit 69f18e3 into code-charity:master Nov 18, 2023
@ImprovedTube
Copy link
Member

Wow

@ImprovedTube
Copy link
Member

ImprovedTube commented Nov 18, 2023

what about making if(this.storage.player_hamburger_button === true){ the first line of the function? @PG-257811
(, so that the rest doesn't run billions of times)

3c345dc

  • `else if (camelized_key === 'playerHamburgerButton') { if(ImprovedTube.storage.player_hamburger_button == false) {document.querySelector('.custom-hamburger-menu')?.remove(); ...

ImprovedTube added a commit that referenced this pull request Nov 18, 2023
ImprovedTube added a commit that referenced this pull request Nov 18, 2023
@pg2511
Copy link
Member Author

pg2511 commented Nov 19, 2023

Yes, @ImprovedTube. Absolutely! the first line of the function to avoid unnecessary execution of the subsequent code, in the same manner as we have done for fit to window button and popup-player button.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants