-
-
Notifications
You must be signed in to change notification settings - Fork 551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixing PiP / Auto PiP #2457
fixing PiP / Auto PiP #2457
Conversation
+ close Auto PIP when returning to source Tab (player_autoPip_outside)
satus.components.select dispatches 'render' Event on component.render, fixes updating player_quality by triggering its on.render sections can be functions was breaking modals, make exception modal 'content' can be a function satus.indexOf was always broken satus.getProperty was always broken
4k is the known name. "Message": "2160p - 4K" https://trends.google.com/trends/explore?date=all&q=4k,2160p,full%20hd,1080p,8k
( https://github.com/ruffle-rs/ruffle ( https://github.com/swf2js/swf2js ) , ( just for fun: |
which 4K, DCI 4K is 4096 x one of many choices, like you got 4K DCI full frame 4096 x 2160, 4K DCI Scope 4096 x 1716 etc :] Exact industry name for 16:9 3840 × 2160 as on YT is 4K UHD :) But that wasnt the reason for this change, code works only if all numerical resolution values are directly in player_quality.options with no lookup from messages.json + it makes little sense to keep it in language/messages.json translate tables, its not like 4K has different names in different languages :). This was my favorite type of patch - fixed a bunch of things and its "+220 −218" barely changed size :). Still needs a lot of testing, as Chrome PiP is very fragile not to mention relations between different states arent really simple. I forgot to switch it to draft when I went for a nap before pushing last changes :] #2458 |
Minus ~24 linter errors, 66 -> 42 .