Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update player.js finish fixing player_quality #2458

Closed
wants to merge 8 commits into from
Closed

Update player.js finish fixing player_quality #2458

wants to merge 8 commits into from

Conversation

raszpl
Copy link
Contributor

@raszpl raszpl commented Jul 7, 2024

finish fixing player_quality
smaller code
reshuffle order so quality and codec settings are grouped together
hide unimplemented optimize_codec_for_hardware_acceleration
removing "block_Codec_Alert_VP9", its same as "block_Codec_Alert_h264"

"+60 −109" and down to 39 ESLint errors :-)

@raszpl raszpl marked this pull request as ready for review July 7, 2024 21:26
@raszpl raszpl marked this pull request as draft July 7, 2024 21:28
@raszpl raszpl marked this pull request as ready for review July 7, 2024 21:35
@ImprovedTube
Copy link
Member

"block_Codec_Alert_VP9" is appreciated! 🥹

@raszpl raszpl mentioned this pull request Jul 7, 2024
@raszpl
Copy link
Contributor Author

raszpl commented Jul 7, 2024

"block_Codec_Alert_VP9" is appreciated! 🥹

what do you mean? it was same message twice

   "block_Codec_Alert_h264": {
        "message": "You need either H.264 or VP9 enabled for Youtube to play videos."
    },
    "block_Codec_Alert_VP9": {
        "message": "You need either VP9 or H.264 enabled for Youtube to play videos."
    },

@raszpl
Copy link
Contributor Author

raszpl commented Jul 7, 2024

Hmm looks like codec relationship is outdated and needs update. Just checked [COSTA RICA IN 4K 60fps HDR (ULTRA HD)] https://www.youtube.com/watch?v=LXb3EKWsInQ

270     mp4   1920x1080   30    │ ~398.99MiB  5025k m3u8  │ avc1.640028    5025k video only
137     mp4   1920x1080   30    │  250.39MiB  3155k https │ avc1.640028    3155k video only          1080p, mp4_dash
614     mp4   1920x1080   30    │ ~178.92MiB  2254k m3u8  │ vp09.00.40.08  2254k video only
248     webm  1920x1080   30    │  109.29MiB  1377k https │ vp9            1377k video only          1080p, webm_dash
620     mp4   2560x1440   30    │ ~605.97MiB  7632k m3u8  │ vp09.00.50.08  7632k video only
271     webm  2560x1440   30    │  474.97MiB  5984k https │ vp9            5984k video only          1440p, webm_dash
625     mp4   3840x2160   30    │ ~  1.13GiB 14527k m3u8  │ vp09.00.50.08 14527k video only
313     webm  3840x2160   30    │  919.33MiB 11582k https │ vp9           11582k video only          2160p, webm_dash

looks like YT got rid of high res versions in AV1 :( WTF Google

edit: even [AV1 video codec for YouTube upload 10000Kbs 4K 24FPS | Part 2 of 7 | Includes download link and info] https://www.youtube.com/watch?v=UC3GWFmzeeo&list=PLleKChtNUwZRrKmDtY33-3b2a9kmmqekE&index=3

270 mp4   1920x1012   24    │ ~  22.97MiB 2964k m3u8  │ avc1.640028   2964k video only
137 mp4   1920x1012   24    │    12.38MiB 1595k https │ avc1.640028   1595k video only          1080p, mp4_dash
614 mp4   1920x1012   24    │ ~  14.52MiB 1873k m3u8  │ vp09.00.40.08 1873k video only
248 webm  1920x1012   24    │     6.01MiB  774k https │ vp9            774k video only          1080p, webm_dash
620 mp4   2560x1350   24    │ ~  35.72MiB 4609k m3u8  │ vp09.00.50.08 4609k video only
271 webm  2560x1350   24    │    17.94MiB 2311k https │ vp9           2311k video only          1440p, webm_dash
625 mp4   3840x2026   24    │ ~  64.78MiB 8360k m3u8  │ vp09.00.50.08 8360k video only
313 webm  3840x2026   24    │    37.68MiB 4854k https │ vp9           4854k video only          2160p, webm_dash

no longer offers AV1 output
Looks like YT killed AV1 for >1080p resolutions :( Can you confirm that on your end before I make adjustments? Can you get 2-4K out of YT with VP9 disabled?
So far I found random "Av1 is what they use for YouTube Premium subscribers when you select the better quality" comment, but also totally contradicting https://www.androidpolice.com/youtube-google-av1-codec-android-video/ suggesting everything should be available on AV1. Im confused.

@raszpl raszpl marked this pull request as draft July 7, 2024 21:48
@raszpl raszpl marked this pull request as ready for review July 7, 2024 22:08
@raszpl raszpl closed this by deleting the head repository Jul 8, 2024
@ImprovedTube
Copy link
Member

just like your code yet didn't suggest to block both H.264 and VP9? 💭

https://www.reddit.com/r/AV1/comments/1b0fkxn/live_world_adoption_map_of_av1_codec

same

almost 😅 Noticed this detail before. I remembered it wasnt always in your code. 534e0ba#diff-7beffd5ac0c7f01f2b63b1f9cf226e646ca222ab1f002779f7acde47d7c886b0 @unnamed-orbert 👋)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants