-
-
Notifications
You must be signed in to change notification settings - Fork 551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update player.js finish fixing player_quality #2458
Conversation
…der so quality and codec settings are grouped together, hide unimplemented optimize_codec_for_hardware_acceleration
"block_Codec_Alert_VP9" is appreciated! 🥹 |
what do you mean? it was same message twice
|
Hmm looks like codec relationship is outdated and needs update. Just checked [COSTA RICA IN 4K 60fps HDR (ULTRA HD)] https://www.youtube.com/watch?v=LXb3EKWsInQ
looks like YT got rid of high res versions in AV1 :( WTF Google edit: even [AV1 video codec for YouTube upload 10000Kbs 4K 24FPS | Part 2 of 7 | Includes download link and info] https://www.youtube.com/watch?v=UC3GWFmzeeo&list=PLleKChtNUwZRrKmDtY33-3b2a9kmmqekE&index=3
no longer offers AV1 output |
just like your code yet didn't suggest to block both H.264 and VP9? 💭 https://www.reddit.com/r/AV1/comments/1b0fkxn/live_world_adoption_map_of_av1_codec
almost 😅 Noticed this detail before. I remembered it wasnt always in your code. 534e0ba#diff-7beffd5ac0c7f01f2b63b1f9cf226e646ca222ab1f002779f7acde47d7c886b0 @unnamed-orbert 👋) |
finish fixing player_quality
smaller code
reshuffle order so quality and codec settings are grouped together
hide unimplemented optimize_codec_for_hardware_acceleration
removing "block_Codec_Alert_VP9", its same as "block_Codec_Alert_h264"
"+60 −109" and down to 39 ESLint errors :-)