Upgrade fork to v0.10.10 #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IR is stubbed for IR.Reflect.Array to prevent existing programs from breaking. Signed-off-by: Rick Waldron <waldron.rick@gmail.com>
Signed-off-by: Rick Waldron <waldron.rick@gmail.com>
…warycat-master * 'master' of https://github.com/warycat/johnny-five: improve coding style fix jslint Rewrite the arduino starter kit in johnny-five Rewrite the arduino starter kit in johnny-five
Signed-off-by: Rick Waldron <waldron.rick@gmail.com>
This "feature" has been nothing but a "bug". Unless your doing basic GPIO, this is not useful and more often then not it's wrong. Signed-off-by: Rick Waldron <waldron.rick@gmail.com>
- Animation.normalize now normalizes to `value` property from `degrees` - Use `value` for internal keyFrames Signed-off-by: Rick Waldron <waldron.rick@gmail.com>
opts.pulldown enables the built-in pull-down resistor on platforms that support it (raspi-io)
* Let's temporarily stopped pin-nannying and see what happens. This "feature" has been nothing but a "bug". Unless your doing basic GPIO, this is not useful and more often then not it's wrong. Signed-off-by: Rick Waldron <waldron.rick@gmail.com> * Fixed a typo
Signed-off-by: Rick Waldron <waldron.rick@gmail.com>
Signed-off-by: Rick Waldron <waldron.rick@gmail.com>
Signed-off-by: Rick Waldron <waldron.rick@gmail.com>
Signed-off-by: Rick Waldron <waldron.rick@gmail.com>
…er used "state" var. Signed-off-by: Rick Waldron <waldron.rick@gmail.com>
… original source/inspiration material. Signed-off-by: Rick Waldron <waldron.rick@gmail.com>
… accessors for IMU controller wrappers, based on components property value Signed-off-by: Rick Waldron <waldron.rick@gmail.com>
Signed-off-by: Rick Waldron <waldron.rick@gmail.com>
…ts as needed. Signed-off-by: Rick Waldron <waldron.rick@gmail.com>
Signed-off-by: Rick Waldron <waldron.rick@gmail.com>
Signed-off-by: Rick Waldron <waldron.rick@gmail.com>
Signed-off-by: Rick Waldron <waldron.rick@gmail.com>
Signed-off-by: Rick Waldron <waldron.rick@gmail.com>
Signed-off-by: Rick Waldron <waldron.rick@gmail.com>
…Fixes rwaldrongh-1314 "Display" does not include "backlight" Signed-off-by: Rick Waldron <waldron.rick@gmail.com>
Signed-off-by: Rick Waldron <waldron.rick@gmail.com>
Signed-off-by: Rick Waldron <waldron.rick@gmail.com>
Signed-off-by: Rick Waldron <waldron.rick@gmail.com>
Signed-off-by: Rick Waldron <waldron.rick@gmail.com>
Signed-off-by: Rick Waldron <waldron.rick@gmail.com>
…-1291 (rwaldron#1312) Signed-off-by: Rick Waldron <waldron.rick@gmail.com>
…ron#1320) * Add support for CSS functional notation to Led.RGB.color Adds support for CSS functional notation (e.g. `"rgb(255, 255, 0)"`) to the `color()` method on the Led.RGB prototype. Supports: - `rgb(r, g, b)` - `rgba(r, g, b, a)` where the alpha value in the range 0-1 modifies the color as an intensity function using `RGB.ToScaledRGB()` - `rgba(r, g, b)` and `rgb(r, g, b, a)` to comply with the [CSS Color Module Level 4 Draft](https://drafts.csswg.org/css-color/#rgb-functions) * Add support for functional notation without commas Also part of the CSS color level 4 spec. * Fix lint errors
Signed-off-by: Rick Waldron <waldron.rick@gmail.com>
Signed-off-by: Rick Waldron <waldron.rick@gmail.com>
Signed-off-by: Rick Waldron <waldron.rick@gmail.com>
* Fix "Cannot read property 'setUp' of undefined" * Deflake Animation keyframeEasing test
* Fix Piezo.prototype.note() The `note()` method was passing a frequency (Hz) to the `tone()` method, which is expecting to receive a duty cycle (μs), leading to the wrong note being played. The solution is for `note()` to call `frequency()` instead, which will do the appropriate conversion. Since it took me a while to understand the relationships between `tone`, `frequency` and `note` I've added some documentation to those methods to clear things up for the next person. I've also made some unit tests more aggressive about checking that values are converted appropriately as they're passed around, and commented note-frequency-duty equivalencies to help the test read nicer. * Fix lint error * Address review feedback - Test that `note()` is case-insensitive - Better description of default octave - One-line Piezo.prototype.note - s/frequncy/frequency - Note tests demonstrate the difference between note letter and octave number better
Signed-off-by: Rick Waldron <waldron.rick@gmail.com>
Sets package version to 'v0.10.10-cdo.0'.
|
Update: I loaded this into Maker Toolkit on my local machine and did some manual testing, also ran unit tests. Everything's looking good! |
Hamms
approved these changes
Apr 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream johnny-five was on v0.9.62 when this fork was created. It's now on v0.10.10. There's no urgent need for this upgrade but it includes better tests and a handful of bugfixes, along with some changes I sent upstream recently.
The only conflict I had to resolve was the package version in
package.json- I've set it tov0.10.10-cdo.0since our branch still contains customizations.Not yet tested with Maker Toolkit - I'll do that (and any necessary fixes) when we upgrade the dependency in our main repo.