Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(utils): add file size logging #65

Merged
merged 22 commits into from
Oct 1, 2023
Merged

feat(utils): add file size logging #65

merged 22 commits into from
Oct 1, 2023

Conversation

BioPhoton
Copy link
Collaborator

@BioPhoton BioPhoton commented Sep 22, 2023 •
edited
Loading

This PR includes:

  • formatBytes function and tests
  • logPersisted files function and tests
  • log the files in the CLI collect command

closes #59

vmasek
vmasek previously approved these changes Sep 22, 2023
View reviewed changes
@BioPhoton BioPhoton requested review from vmasek and removed request for matejchalk and vmasek September 22, 2023 21:48
BioPhoton and others added 6 commits September 23, 2023 10:07
@BioPhoton @matejchalk
Update packages/utils/src/lib/collect/implementation/utils.ts
f06b623 
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
@BioPhoton @matejchalk
Update packages/utils/src/lib/collect/implementation/utils.ts
f4ec948 
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
@BioPhoton @matejchalk
Update packages/utils/src/lib/collect/implementation/persist.ts
8a7d0fb 
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
@BioPhoton @matejchalk
Update packages/utils/src/lib/collect/implementation/persist.ts
38acb3a 
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
@BioPhoton
refactor(utils): fix tests
ee100a7
@BioPhoton
refactor(utils): fix tests 2
2679f77
matejchalk
matejchalk previously approved these changes Sep 24, 2023
View reviewed changes
@BioPhoton BioPhoton enabled auto-merge (squash) September 25, 2023 10:18
@BioPhoton BioPhoton disabled auto-merge September 25, 2023 10:18
@BioPhoton BioPhoton changed the title feeat(utils): add file size logging feat(utils): add file size logging Sep 25, 2023
matejchalk
matejchalk previously approved these changes Sep 26, 2023
View reviewed changes
ChristopherPHolder
ChristopherPHolder approved these changes Oct 1, 2023
View reviewed changes
Copy link

@ChristopherPHolder ChristopherPHolder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both things are minor and I agree that if all test are passing the PR can be merged

packages/utils/src/lib/collect/implementation/utils.spec.ts Show resolved Hide resolved
package.json Show resolved Hide resolved
@BioPhoton BioPhoton merged commit c46046f into main Oct 1, 2023
6 checks passed
@BioPhoton BioPhoton deleted the add-filesize-logging branch October 1, 2023 21:00
@BioPhoton BioPhoton mentioned this pull request Oct 18, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristopherPHolder ChristopherPHolder ChristopherPHolder approved these changes

@vmasek vmasek vmasek approved these changes

@matejchalk matejchalk matejchalk left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Log report file size
4 participants
@BioPhoton @vmasek @matejchalk @ChristopherPHolder