-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move core logic into new "core" package #73
Milestone
Comments
3 tasks
This was referenced Oct 1, 2023
BioPhoton
added a commit
that referenced
this issue
Oct 2, 2023
As this refactoring is pretty involved in the whole code base i suggest the changes in the following order:
|
BioPhoton
added a commit
that referenced
this issue
Oct 2, 2023
This PR includes a small refactoring to align with #73
BioPhoton
added a commit
that referenced
this issue
Oct 2, 2023
Closing since all the mentioned PRs have been merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Proposal
utils
- too much?utils
could be only for more generic helper functions, e.g.executeProcess
or Markdown formatterscollect
andexecutePlugin
could live incore
packageMotivation
core
package should be for programmatic usage of our core logic (e.g. used by our GitHub Action)plugin-*
packages can import fromutils
ormodels
, but not fromcore
cli
project might not then need multiple entry points (only bin)cli
andcore
is quite common in other CLI-first projects (e.g. jest or graphql-code-generator)Nx graph
The text was updated successfully, but these errors were encountered: