Skip to content
This repository has been archived by the owner on May 15, 2021. It is now read-only.

ROGUE v2 #77

Merged
merged 9 commits into from
Nov 29, 2020
Merged

ROGUE v2 #77

merged 9 commits into from
Nov 29, 2020

Conversation

code-rgb
Copy link
Owner

No description provided.

code-rgb and others added 8 commits November 29, 2020 11:08
* okay xD rewiting inline buttons from scratch

* initial changes

* adding bunch of logger and prints

* improved ibutton

* Update help.py

* Update buttons.py
This will fix this https://nekobin.com/sayufenose error.

It is caused by the use of apostrophe + s ('s) in  the file name. 
You can reproduce this error by making a directory like `Newton's law of motion/lect1.mp4` . And after giving upload command.

(It will give you error while taking screenshot for lect1.mp4)
Co-authored-by: Sourcery AI <>
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Nov 29, 2020

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.63%.

Quality metrics Before After Change
Complexity 27.73 😞 35.43 ⛔ 7.70 👎
Method Length 82.89 🙂 82.99 🙂 0.10 👎
Working memory 15.69 ⛔ 15.98 ⛔ 0.29 👎
Quality 52.55% 🙂 51.92% 🙂 -0.63% 👎
Other metrics Before After Change
Lines 3491 3574 83
Changed files Quality Before Quality After Quality Change
userge/config.py 45.78% 😞 44.87% 😞 -0.91% 👎
userge/core/methods/messages/edit_message_text.py 58.83% 🙂 58.83% 🙂 0.00%
userge/core/methods/messages/send_as_file.py 65.47% 🙂 65.47% 🙂 0.00%
userge/core/methods/messages/send_message.py 55.05% 🙂 55.05% 🙂 0.00%
userge/plugins/help.py 28.69% 😞 27.25% 😞 -1.44% 👎
userge/plugins/bot/bot_forwards.py 55.20% 🙂 55.06% 🙂 -0.14% 👎
userge/plugins/bot/buttons.py 48.04% 😞 50.21% 🙂 2.17% 👍
userge/plugins/bot/inline_help.py 74.64% 🙂 74.56% 🙂 -0.08% 👎
userge/plugins/misc/gdrive.py 63.76% 🙂 63.93% 🙂 0.17% 👍
userge/utils/tools.py 62.48% 🙂 62.48% 🙂 0.00%
userge/utils/spotify/spotify_db_class.py 95.29% ⭐ 95.29% ⭐ 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
userge/plugins/help.py inline_answer 217 ⛔ 1815 ⛔ 42 ⛔ 0.13% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
userge/plugins/misc/gdrive.py _GDrive._search 25 😞 237 ⛔ 23 ⛔ 21.02% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
userge/plugins/help.py helpme 20 😞 261 ⛔ 22 ⛔ 23.49% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
userge/plugins/misc/gdrive.py _GDrive._upload_file 14 🙂 291 ⛔ 33 ⛔ 24.43% ⛔ Try splitting into smaller methods. Extract out complex expressions
userge/plugins/bot/buttons.py noformat_message 26 😞 196 😞 18 ⛔ 26.10% 😞 Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.

@code-rgb code-rgb merged commit 08b7d27 into alpha Nov 29, 2020
@code-rgb code-rgb deleted the release branch November 29, 2020 07:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants