Skip to content

fix #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2017
Merged

fix #1

merged 1 commit into from
Apr 11, 2017

Conversation

kayoubi
Copy link

@kayoubi kayoubi commented Apr 11, 2017

the import was wrong and I had to remove the other two lines, otherwise I get registerHandler is not defined and unregisterHandler is not defined respectively

it seems to work fine now

@codeNgamer
Copy link
Owner

codeNgamer commented Apr 11, 2017

@kayoubi why did you remove lines:

+   this.props.navigationStateHandler[registerHandler](this);
+   this.props.navigationStateHandler[unregisterHandler](this);

registerHandler and unregisterHandler are placeholders in this context meaning you can swap them out for methods like:

+   this.props.navigationStateHandler.registerRefreshHandler(this);
+   this.props.navigationStateHandler.unregisterRefreshHandler(this);
navigationStateHandler method = "register" + ActionConst["propertyName"] + "Handler"

or

navigationStateHandler method = "unregister" + ActionConst["propertyName"] + "Handler" 

@kayoubi
Copy link
Author

kayoubi commented Apr 11, 2017

@codeNgamer Ah, I see, just reverted those two lines

@codeNgamer codeNgamer merged commit b3036f5 into codeNgamer:master Apr 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants