Update godot-cpp & add a more accessible scons command to readme #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Which crash does it fix exactly? I already pushed the changes needed for RC1. Was there another crash? Additionally, might wanna display both scons commands. |
|
Maybe it's because of this: godotengine/godot#72926 That or because the version from the assets library it's still on 0.14 |
|
Yeah, but I don't see why that would cause a crash. |
|
Then more likely it's the outdated version of the assets library |
|
Sorry I'm late to the party. Could well be that you beat me to it @codecat . I could repurpose this PR to make the readme changes if you prefer? |
|
Definitely, if you can update the PR that'd be great! |
|
I'll sort the readme in another PR at a later date |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This version fixes a crash with Godot 4 RC1