Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add status, start/end time, and matchline for bddStep event #2678

Merged
merged 2 commits into from
Dec 18, 2020

Conversation

ktryniszewski-mdsol
Copy link
Contributor

@ktryniszewski-mdsol ktryniszewski-mdsol commented Nov 17, 2020

Motivation/Description of the PR

I wanted to enhance bddStep reporting a bit more as a follow up to PR #2343
Just as @wojtkowiak reported initially when there are no helper methods fired in a bdd step, it is hard to extract relevant information. Emitting an event was a good step forward. However, I have add some more properties - status, start/end time, error, and step match location for enhanced reporting when the event is fired.

Applicable helpers:

  • WebDriver
  • Puppeteer
  • Nightmare
  • REST
  • FileHelper
  • Appium
  • Protractor
  • TestCafe
  • Playwright

Applicable plugins:

  • allure
  • autoDelay
  • autoLogin
  • customLocator
  • pauseOnFail
  • puppeteerCoverage
  • retryFailedStep
  • screenshotOnFail
  • selenoid
  • stepByStepReport
  • wdio

Type of change

  • 🔥 Breaking changes
  • 🚀 New functionality
  • 🐛 Bug fix
  • 📋 Documentation changes/updates
  • ♨️ Hot fix
  • 🔨 Markdown files fix - not related to source code
  • 💅 Polish code

Checklist:

  • Tests have been added
  • Documentation has been added (Run npm run docs)
  • Lint checking (Run npm run lint)
  • Local tests are passed (Run npm test)

@ktryniszewski-mdsol ktryniszewski-mdsol changed the title Add status, start/end time, and matchline for bddStep event feat: add status, start/end time, and matchline for bddStep event Nov 17, 2020
@ktryniszewski-mdsol
Copy link
Contributor Author

@DavertMik Do you have a minute to take a quick look at this?

@DavertMik
Copy link
Contributor

Thanks, this PR looks good!
Sorry for the delay reviewing it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants