Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error suppression for failed gherkin step #2745

Merged
merged 2 commits into from
Feb 1, 2021

Conversation

ktryniszewski-mdsol
Copy link
Contributor

@ktryniszewski-mdsol ktryniszewski-mdsol commented Jan 4, 2021

Motivation/Description of the PR

Applicable helpers:

  • WebDriver
  • Puppeteer
  • Nightmare
  • REST
  • FileHelper
  • Appium
  • Protractor
  • TestCafe
  • Playwright

Applicable plugins:

  • allure
  • autoDelay
  • autoLogin
  • customLocator
  • pauseOnFail
  • puppeteerCoverage
  • retryFailedStep
  • screenshotOnFail
  • selenoid
  • stepByStepReport
  • wdio

Type of change

  • 🔥 Breaking changes
  • 🚀 New functionality
  • 🐛 Bug fix
  • 📋 Documentation changes/updates
  • ♨️ Hot fix
  • 🔨 Markdown files fix - not related to source code
  • 💅 Polish code

Checklist:

  • Tests have been added
  • Documentation has been added (Run npm run docs)
  • Lint checking (Run npm run lint)
  • Local tests are passed (Run npm test)

@leonardobazico
Copy link
Contributor

I'm looking for this change, I've found a silent error on my tests.

@leonardobazico
Copy link
Contributor

@ktryniszewski-mdsol do you have any contact that would help prioritize this?

@ktryniszewski-mdsol
Copy link
Contributor Author

@ktryniszewski-mdsol do you have any contact that would help prioritize this?

Hopefully @DavertMik can take a look soon and merge. In the meantime you can probably just downgrade to 3.0.2 unless there was something you specifically needed in the higher version

Copy link
Collaborator

@Georgegriff Georgegriff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our unit tests were broken here, swallowing the error, so it missed this! I've fixed the unit tests in this pr too :) thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants